[PATCH] Setting rally point on attackable entities

[Jonathan Waller]

Players may want to set the rally point on an enemy entity and have the trained/ungarrisoned units attack. How should this be implemented for mobile enemies?

[Dmitry]

It would be nice if it could be a possibility to set a rally point of unit-prodution buildings to existing units.

[mimo]

Setting a rallyPoint with moveAttack was already possible for every position in the map, see lines 492 and followings on that same file: when you simply pick a position, the rallyPoint will be to move your units there; but if you press Ctrl while picking the point, the rally Point will be to move-attack there. So this patch only adds the fact that, when the position is an enemy structure, you have by default the move-attack without the need for Ctrl ? I would still prefer to keep the choice to be able to simply move there.

I think the goal of this ticket was to have an attack order on a given entity (not move attack on a given position).

[mimo]

well, I've not tested your new patch but I've the impression you miss a part there: you must add the new orders in simulation/helpers/RallyPointCommands.js otherwise I suppose you fall back to the default order (walk).

And you must also check what happens if the entity is moving and going out-of-los, or if you queue several attack orders. For example, if the first entity is killed or out-of-los, will it go directly to attack the second entity or will it first walk to the last known position of the first entity before ?

[maveric]

There are some issues in patch but you can see how its going to work.

[sanderd17]

In 16680:

Allow setting rallypoint on enemy entities. Patch by maveric, fixes #1046