[PATCH] Hotkey to toggle silhouettes

[historic_bruno]

Silhouettes are the player-colored shape of a unit when it's obstructed by something else. Sometimes they can be distracting, so a hotkey to turn this feature on/off would be nice :)

[Philip Taylor]

Hotkeys sound too easy for someone to accidentally press, and then get very confused a while later when they realise they can't see any silhouettes any more and have no idea how to get them back. Maybe putting it in the (not-yet-existent) advanced options menu would be better, so people probably only trigger it on purpose.

[historic_bruno]

I agree in principle, but we have other hotkeys that are much worse, namely the GUI show/hide key :P

[Erik Johansson]

Well, now you need to press Alt+G to hide the GUI. In my opinion that's not something you're too likely to press by accident. But true, things like that are probably most appropriate to go in an advanced options menu eventually :)

[Daniele]

First attempt for ticket task

[Jonathan Waller]

Hi, thanks for the patch, it looks like a reasonable approach. A couple of comments:

You should initialize m_Silhouettes, the other booleans are done near line 424 in Renderer.cpp.

We would prefer it if you could handle the hotkey press in the javascript GUI scripts. The wireframe is a slight anomaly in being handled by the C++. Try looking at the fancyWater setting to see how to interface with the javascript.

[Daniele]

Sure, i'll go for it today or tomorrow

[Mitchell K]

I've implemented it in the javascript/xml. I've also made it load the default value from default.cfg.

I wasn't exactly sure where to put it in there, since there isn't really a render settings section, so I added it after fancywater, shadows, shadowpcf and vsync (system settings). I put the actual hotkey in the system settings hotkeys as well (after wireframe). I didn't name it "silhouettes.toggle" since that doesn't really seem to be used consistently anyway (but if you wanted it that way, all that would be changed is line 117 of default.cfg and line 59 of session.xml).

It also wasnt clear where to put the action in session.xml, so I added it by the menu and chat toggling actions.

[Mitchell K]

uses javascript/xml to handle hotkey press

[ben]

In 11779:

Adds config and hotkey options for toggling unit silhouettes, based on patches by Ello and mk12. Fixes #1186.

[ben]

In 11782:

Adds silhouettes option to in-game settings menu. Refs #1186