#1206 closed enhancement (fixed)
[PATCH] Garrison UI Enhancement: Shift-Click Removal
| Reported by: | michael | Owned by: | leper |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 10 |
| Component: | UI & Simulation | Keywords: | Garrison, UI |
| Cc: | Patch: |
Description
Shift-Click the unit icons in Garrison UI panel to unload all of that type.
Be sure to make this distinction known in the tooltip: "Single-click to unload 1. Shift-click to unload all of this type."
Attachments (2)
Change History (8)
by , 12 years ago
| Attachment: | #1206-2012-03-18.patch added |
|---|
comment:1 by , 12 years ago
| Keywords: | review added |
|---|---|
| Summary: | Garrison UI Enhancement: Shift-Click Removal → [PATCH] Garrison UI Enhancement: Shift-Click Removal |
comment:2 by , 12 years ago
| Component: | Core engine → GUI & Simulation |
|---|
comment:3 by , 12 years ago
by , 12 years ago
| Attachment: | #1206-2012-03-21.patch added |
|---|
comment:4 by , 12 years ago
| Owner: | set to |
|---|
Nice to know that multiple hotkeys can use the same key. Thanks for reminding me to grep through the ai folders.
Note:
See TracTickets
for help on using tickets.
A few comments on the patch:
You reuse the batchtrain hotkey. I think it would be better to define a new one since they are different tasks.
You send the "Unable to ungarrison unit" from within a loop. It should be taken out of the loop so that only one message is sent. It would be nice if you could make the message plural/singular as well.
The AI scripts use the unload command (the common-api has a function, it isn't actually used yet though), so this needs updating to match your changes. Generally if you ever change a function or command it is good to do a search so you can see all of the places it is used.