[PATCH] move the banner of spawn point along with the unit

[Евгений]

If I set a spawn point of any buildings on unit that can transport people(like Aries), and move this units, the banner of spawn point not move, but people from this buildings will continue to go to the Aries. This can be confusing. Need to move the banner along with the Aries.

[Itms]

Hi everyone, this is a patch implementing this functionality. Please share your thoughts!

NB: This won't work for animals, because hunting orders are "gather-near-position" orders and do not target entities.

[Itms]

Added a TODO to reference a possible future improvement.

[Itms]

Additional style fix

[leper]

In 15288:

Recompute rally point lines when the rally point is set on a moving unit.
Does not account for setting rally points on units that can move into the FoW/SoD.
Recalculates paths even if the rally points are not displayed.
Refactors UpdateMarkers() to remove some indentation levels.
Based on patch by Itms. Fixes #1257.

[leper]

Thanks for the patch. I changed the recomputation of the rally point lines to only the current and (if existing) next line. (There are queued rally point lines (use shift to set them), and recomputing ones that don't change is useless and those call into the pathfinder)

It would be nice if you could take a look to not recompute those lines/markers if the rally point isn't displayed currently, but do so if the building is selected (and if that yields a noticable delay, which would be bad).

[mimo]

I would add some test in RallyPoint.GetPositions to avoid useless calls to cmpRallyPointRenderer.UpdatePosition:

either if (!this.data[i].target) replaced by if (!this.data[i].target OR !Engine.QueryInterface(this.data[i].target, IID_UnitMotion))

or if (this.pos[i].x == targetPosition.x AND this.pos[i].z == targetPosition.y) continue; before this.pos[i] = {"x": targetPosition.x, "z": targetPosition.y};

[leper]

In 15296:

Check if the position changed before updating it for rally points set on entities. Refs #1257.

[Itms]

In 15511:

Fix OOS problems caused by an unwanted modification of the simulation state by the GUI.

Refs #1257

[Itms]

In 15512:

Fix previous commit, refs #1257