Ticket #1370 (closed defect: fixed)
Implement defeat music
| Reported by: | vladislav | Owned by: | leper |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 11 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | brian |
Description (last modified by historic_bruno) (diff)
See attached screenshot
Attachments
Change History
comment:1 Changed 13 months ago by feneur
- Priority changed from Release Blocker to Should Have
Hmm, does the defeat music not play at all? Doing a quick test I notice it does play, so it seems like a weird warning for an issue that doesn't exist (or rather: there might be a programming error, but it doesn't affect gameplay). Something to look into sure, but definitely not a release blocker.
comment:2 Changed 13 months ago by historic_bruno
- Cc brian added
- Component changed from Music & Sound FX to UI & Simulation
- Description modified (diff)
- Summary changed from Unrecognized music type: defeat to Implement defeat music
Defeat music isn't implemented as far as I know, the first message in the console is not an error, but a reminder to implement it :) This may be fixed as part of our planned sound system overhaul.
(The warning/error are separate, AI-related issues.)
comment:5 follow-up: ↓ 6 Changed 11 months ago by leper
Is this error still occuring?
Defeat music (and victory music) should work as of r12020. Probably some call site used defeat (or global.music.states.defeat) instead of global.music.states.DEFEAT.
comment:6 in reply to: ↑ 5 Changed 11 months ago by historic_bruno
Replying to leper:
Is this error still occuring?
You have to play a civ that has defeat or victory music defined in the civ data file, like Romans, and then check the console after the game starts (it's a direct console output). The problem is there's no case in Music.storeTracks() to handle loading defeat or victory music. If it's trivial to fix, it may be worth doing short term, but eventually the music logic should be moved outside of JS per what used to be #961 :)
comment:7 Changed 11 months ago by leper
- Owner set to leper
- Status changed from new to closed
- Resolution set to fixed
In 12024:
comment:8 Changed 11 months ago by leper
I went ahead and fixed it (I also changed the console logging to warnings, so that they show up in the logs).
Regarding #961: I think we should leave some of the music logic in JS, but we should move that out of the gui code as it doesn't fit there. We should probably reopen/create a new ticket for this task after the new sound manager is completed.
