Out of sync error

[historic_bruno]

Get this OOS error with r11758, on the default map, 2 human players (no AIs), after tasking one of player 1's units to move. Logs are attached, a diff tool shows the only difference to be some extra data in the host's tech manager modificationsCache for player 1:

    },
    "Attack/Melee/Hack": {
      "1170": 6,
      "1461": 15
    },
    "Attack/Melee/Pierce": {
      "1170": 0,
      "1461": 0
    },
    "Attack/Melee/Crush": {
      "1170": 0,
      "1461": 0
    },
    "Armour/Hack": {
      "1170": 1,
      "1461": 9
    },
    "Armour/Pierce": {
      "1170": 1,
      "1461": 8
    },
    "Armour/Crush": {
      "1170": 5,
      "1461": 9
    },
    "ResourceGatherer/BaseSpeed": {
      "1170": 1,
      "1461": 1
    },
    "ResourceGatherer/Rates/food.fish": {
      "1170": 0.5
    },
    "ResourceGatherer/Rates/food.fruit": {
      "1170": 2
    },
    "ResourceGatherer/Rates/food.grain": {
      "1170": 0.4
    },
    "ResourceGatherer/Rates/food.meat": {
      "1170": 1
    },
    "ResourceGatherer/Rates/metal.ore": {
      "1170": 0.5
    },
    "ResourceGatherer/Rates/stone.rock": {
      "1170": 0.5
    },
    "ResourceGatherer/Rates/stone.ruins": {
      "1170": 5
    },
    "ResourceGatherer/Rates/treasure": {
      "1170": 1,
      "1461": 1
    },
    "ResourceGatherer/Rates/wood.ruins": {
      "1170": 5
    },
    "ResourceGatherer/Rates/wood.tree": {
      "1170": 0.5

I suspect GuiInterface.GetEntityState() is indirectly triggering some unsynchronized calls to ApplyModifications(). Is there a way to simply not synchronize the cache? (And a getter should probably never modify the simulation state as it's unexpected behavior)

[vts]

Can reproduce this with the same revision, both running of windows machines (Vista and Win7). Game went out of sync after about ~5 seconds of playtime.

[Jonathan Waller]

In 11761:

Don't serialize the technology modifications cache. Fixes #1384.