Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#1513 closed defect (fixed)

[PATCH] Bug on Deep Forest random map

Reported by: historic_bruno Owned by: FeXoR
Priority: Should Have Milestone: Alpha 11
Component: UI & Simulation Keywords:
Cc: FeXoR, O.Davoodi Patch:

Description

See http://www.wildfiregames.com/forum/index.php?showtopic=16201 for original report.

The problem is Deep Forest is placing chickens (possibly other things?) inside the player's starting CC, which indirectly cripples AI but it doesn't help the player either :)

Attachments (2)

deepforestbug.jpg (267.5 KB ) - added by historic_bruno 12 years ago.
4 chickens and a pig inside the CC foundation
deep_forest.js (10.4 KB ) - added by FeXoR 12 years ago.
New version of deep_forest.js 2.7.2012

Download all attachments as: .zip

Change History (12)

by historic_bruno, 12 years ago

Attachment: deepforestbug.jpg added

4 chickens and a pig inside the CC foundation

comment:1 by O.Davoodi, 12 years ago

Keywords: random map added
Owner: set to FeXoR

The way those pigs and chickens (and the whole bunch of fauna) are generated in deep-forest is horrible. I can fix it but it is better that FeXoR does it himself.

Last edited 12 years ago by O.Davoodi (previous) (diff)

comment:2 by historic_bruno, 12 years ago

The important thing is just to make sure the starting resources are X tiles away from the civil center, regardless of map size :)

in reply to:  2 comment:3 by O.Davoodi, 12 years ago

Replying to historic_bruno:

The important thing is just to make sure the starting resources are X tiles away from the civil center, regardless of map size :)

Well, he didn't use the standard rmgen functions in this map. Currently those animals are generated the way forests are.

comment:4 by FeXoR, 12 years ago

Sorry for taking so long...

Here's an updated version. It fixes the animals inside the Civil Centre.

It still might happen that animals wind up in a stone or metal resource entity. Deer in the woods might cause a similar problem when surrounded by trees. This will be a bit harder harder to fix though.

BTW, similar things will happen on most random maps for Iberians with their civ bonus walls if any entity that can be gathered from is placed inside a wall.

So in general this is more a problem of entity placement in random maps and that again is caused by RMGEN not being part of simulations...

Replying to Spahbod:

The way those pigs and chickens (and the whole bunch of fauna) are generated in deep-forest is horrible.

Why?

Last edited 12 years ago by FeXoR (previous) (diff)

by FeXoR, 12 years ago

Attachment: deep_forest.js added

New version of deep_forest.js 2.7.2012

comment:5 by FeXoR, 12 years ago

Keywords: review added
Summary: Bug on Deep Forest random map[Patch] Bug on Deep Forest random map

in reply to:  4 ; comment:6 by O.Davoodi, 12 years ago

Replying to FeXoR:

Replying to Spahbod:

The way those pigs and chickens (and the whole bunch of fauna) are generated in deep-forest is horrible.

Why?

You said it yourself:

It still might happen that animals wind up in a stone or metal resource entity. Deer in the woods might cause a similar problem when surrounded by trees. This will be a bit harder harder to fix though.

The fix works and I couldn't find much problems.

comment:7 by O.Davoodi, 12 years ago

Resolution: fixed
Status: newclosed

In 12052:

Fixing the bug on Deep Forest random map by FeXoR. Fixes #1513.

comment:8 by O.Davoodi, 12 years ago

Keywords: random map review removed

in reply to:  6 comment:9 by FeXoR, 12 years ago

Replying to Spahbod:

Replying to FeXoR:

Replying to Spahbod:

The way those pigs and chickens (and the whole bunch of fauna) are generated in deep-forest is horrible.

Why?

You said it yourself:

It still might happen that animals wind up in a stone or metal resource entity. Deer in the woods might cause a similar problem when surrounded by trees. This will be a bit harder harder to fix though.

The fix works and I couldn't find much problems.

Sorry, edited my previous post after you wrote yours.

I really think thats an entity placement problem in general for random maps. But I think that needs further discussion anyways so good to have more than one point of veiw :)

BTW, on most maps there are trees surrounded by other trees. That could cause similar problems for the AI as well.

Last edited 12 years ago by FeXoR (previous) (diff)

comment:10 by Palaxin, 8 years ago

Summary: [Patch] Bug on Deep Forest random map[PATCH] Bug on Deep Forest random map
Note: See TracTickets for help on using tickets.