[PATCH] Some queue orders for citizen-soldiers still need implemented

[michael]

The queue (shift-click) order for citizen-soldiers to drop resources, then go build something does not work. The soldier will skip the drop off part once the 2nd order is made, as if the player never queued the orders to begin with.

[leper]

Some orders (gather-near-position (used by rallypoints), return-resource, attack, heal and garrison) still use the old behaviour. They issue the command to all formation members and the formation disbands, if you add another order a new formation is created and thus the previous tasks (for every unit) are discarded.

The problem is that you can't wait for every unit to finish the task and just queue the new "get-in-formation" order as that isn't what one would expect.

Completely migrating to the new behaviour (keeping the formation intact, while each unit carries out the order on their own) has the problem that defining when a task is finished isn't obvious.

See #592, #593 and #1670.

[leper]

Proper formation order queueing

[leper]

The attached patch should fix #592, #593 and this ticket. #1670 should be done like Deiz outlined in that ticket.

Some testing/review would be appreciated.

[leper]

The special handling for building can be removed too.

[Simon]

Adds a fix for #1624 based on the prior submitted patch by leper

[leper]

In 12911:

Formation order queueing. Fixes #592, #593 and #1716.
Allow changing the formation, while under attack. Fixes #1624. Patch by Simikolon.

[leper]

Just for reference: http://www.wildfiregames.com/forum/index.php?showtopic=16739