#1930 closed defect (fixed)
[PATCH] delayed build bug
| Reported by: | mimo | Owned by: | leper |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 14 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | Patch: |
Description
The bug reported in http://www.wildfiregames.com/forum/index.php?showtopic=17319 is a side-effect of the patch http://trac.wildfiregames.com/ticket/1903 . Here is a possible fix.
Attachments (2)
Change History (7)
by , 11 years ago
| Attachment: | delayedbuild.diff added |
|---|
by , 11 years ago
| Attachment: | delayed_fix.patch added |
|---|
comment:1 by , 11 years ago
| Component: | Core engine → UI & Simulation |
|---|
I'm not sure which of the two solutions is the better one. Your version is short, but it doesn't handle the case where the repair/build order is the last one well IMO. The unit will just stop where it is currently (when the order is executed) and stop there.
While mine will walk to the building (even if it has been constructed/fully repaired) without caring if there are other orders left.
(I have a slight preference for my solution, but I'll ask someone to give us some input on which one to use.)
comment:2 by , 11 years ago
My patch was to fix what was broken by ticket 1903 : when a foundation is completed and thus renamed, we should not renamed it in the builder orders. This bring us back to the state before 1903. Then if people prefer to change this behaviour and walk to the already built building, that's also fine with me.
comment:3 by , 11 years ago
I think leper's patch would be the way to go here. Most other RTS games I'm familiar with handle this situation the same way. As far as I can tell, his patch is ready to be committed.
comment:5 by , 11 years ago
| Keywords: | review removed |
|---|
(see IRC discussion for why we decided upon my patch)
alternate solution