Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#1953 closed defect (fixed)

[PATCH]Unable to change number of players in Atlas after first simulation run or save.

Reported by: sanderd17 Owned by: leper
Priority: Must Have Milestone: Alpha 18
Component: Atlas editor Keywords: patch
Cc: Patch:

Description

Atlas throws errors when you alter the number of players on an existing map, or a map that you at least simulated once.

Afterwards, the file is rather corrupt, and playing it results in the immediate defeat of Player 1, together with a negative population or max population (depending on factors I haven't discovered yet.

Steps to reproduce are on the forum: http://www.wildfiregames.com/forum/index.php?showtopic=17348&hl=&fromsearch=1

Attachments (4)

1953.diff​ (4.7 KB ) - added by trompetin17 9 years ago.
1953.2.diff​ (3.2 KB ) - added by trompetin17 9 years ago.
1953.3.diff​ (2.8 KB ) - added by trompetin17 9 years ago.
1953.4.diff​ (2.9 KB ) - added by trompetin17 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Erik Johansson, 11 years ago

Summary: Unable to change number of layers in Atlas after first run or save. → Unable to change number of players in Atlas after first simulation run or save.

comment:2 by Markus, 11 years ago

Seems similar to #1490.

by trompetin17, 9 years ago

Attachment: 1953.diff​ added

comment:3 by trompetin17, 9 years ago

Keywords: review patch added
Milestone: Backlog → Alpha 18
Summary: Unable to change number of players in Atlas after first simulation run or save. → [PATCH]Unable to change number of players in Atlas after first simulation run or save.

by trompetin17, 9 years ago

Attachment: 1953.2.diff​ added

by trompetin17, 9 years ago

Attachment: 1953.3.diff​ added

by trompetin17, 9 years ago

Attachment: 1953.4.diff​ added

comment:4 by leper, 9 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 16080:

Only delete/create players until the needed number is reached. Patch by trompetin17. Fixes #1953.

Previously we removed all players and created them anew. This caused issues in Atlas,
as some components were recreated, but did not get informed about already existing
entities (eg cmpTechnologyManager). By only creating/deleting players until we obtain
the new number of players we do not have this issue.

comment:5 by leper, 9 years ago

Keywords: review removed

Thanks for the patch.

Note: See TracTickets for help on using tickets.