Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1954 closed defect (fixed)

[PATCH] Non-rounded gains on garisonned merchant ship

Reported by: sanderd17 Owned by: ben
Priority: Should Have Milestone: Alpha 14
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

After garisonning a merchant ship with a trader, it can result in non-rounded gains.

See the attached screenshot.

Attachments (1)

fix-round-trading-gain.patch​ (484 bytes ) - added by Markus 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by sanderd17, 11 years ago

Sorry, screenshot was too big, here it is: ​http://tinypic.com/r/2ps59on/5

by Markus, 11 years ago

Attachment: fix-round-trading-gain.patch​ added

comment:2 by Markus, 11 years ago

Component: Core engine → UI & Simulation
Keywords: simple patch review added
Milestone: Backlog → Alpha 14
Summary: Non-rounded gains on garisonned merchant ship → [PATCH] Non-rounded gains on garisonned merchant ship

comment:3 by ben, 11 years ago

Owner: set to ben
Resolution: → fixed
Status: new → closed

In 13447:

Rounds trader gain to avoid fractions with garrisoned traders in a merchant ship, patch by Markus, fixes #1954

comment:4 by historic_bruno, 11 years ago

Keywords: simple review removed

Thanks for the patch. Also, please don't add the 'simple' keyword with your patches, that is used to indicate available beginner tasks :)

Note: See TracTickets for help on using tickets.