Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1997 closed defect (fixed)

[PATCH] Rounding Failure

Reported by: scythetwirler Owned by: scythetwirler
Priority: Should Have Milestone: Alpha 14
Component: UI & Simulation Keywords: simple patch
Cc: Patch:

Description

Rounding failure after getting the hero Demetrius the Besieger, giving an attack bonus to siege equipment.

Not sure if this has been fixed in the SVN.

Attachments (3)

roundboltshooter.jpg​ (377.1 KB ) - added by scythetwirler 11 years ago.
random.diff​ (1021 bytes ) - added by scythetwirler 11 years ago.
random_without_BUMPUP.diff​ (721 bytes ) - added by scythetwirler 11 years ago.

Download all attachments as: .zip

Change History (11)

by scythetwirler, 11 years ago

Attachment: roundboltshooter.jpg​ added

comment:1 by historic_bruno, 11 years ago

Keywords: simple added

I don't think it has been fixed, there should be more rounding added to the functions of utility_functions.js, like damageTypesToText().

comment:2 by scythetwirler, 11 years ago

Owner: set to scythetwirler

comment:3 by scythetwirler, 11 years ago

Status: new → assigned

by scythetwirler, 11 years ago

Attachment: random.diff​ added

comment:4 by scythetwirler, 11 years ago

I think that fixes it, the BUMPUP may be up for discussion.

comment:5 by scythetwirler, 11 years ago

Keywords: review added
Summary: Rounding Failure → [PATCH] Rounding Failure

comment:6 by scythetwirler, 11 years ago

Keywords: patch added

by scythetwirler, 11 years ago

Attachment: random_without_BUMPUP.diff​ added

comment:7 by peter, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 13540:

  • Round attack numbers in the GUI. Patch by scythetwirler. Fix #1997.
  • Adjust the siege attack tech to add an integer instead of multiply by a percentage.
  • Fix the siege armor tech so the tooltip and the added value match up.

comment:8 by leper, 11 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.