Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2275 closed defect (fixed)

[PATCH] Opening the game manual/settings/exit dialog/resign dialog shouldn't pause a multiplayer game

Reported by: leper Owned by: Michael
Priority: Nice to Have Milestone: Alpha 16
Component: UI & Simulation Keywords: simple patch
Cc: Patch:

Description (last modified by leper)

Opening the in-game manual, settings dialog, exit dialog, or the resign dialog (from the menu) shouldn't pause multiplayer games, but should continue to pause single player games.

Attachments (2)

menu.js.patch (532 bytes ) - added by Michael 10 years ago.
Game is not paused any more in multi player mode when manual is opend.
menu.js.v2.patch (1.1 KB ) - added by Michael 10 years ago.
Now working in some more cases. Normal pause function in MP game remains untouched.

Download all attachments as: .zip

Change History (8)

comment:1 by sanderd17, 10 years ago

Milestone: Backlog

by Michael, 10 years ago

Attachment: menu.js.patch added

Game is not paused any more in multi player mode when manual is opend.

comment:2 by Michael, 10 years ago

Keywords: review patch added
Milestone: BacklogAlpha 16
Owner: set to Michael
Summary: Opening the game manual shouldn't pause a mulitplayer game[PATCH] Opening the game manual shouldn't pause a mulitplayer game

comment:3 by leper, 10 years ago

Description: modified (diff)
Keywords: simple, review patch → simple review patch
Summary: [PATCH] Opening the game manual shouldn't pause a mulitplayer game[PATCH] Opening the game manual/settings/exit dialog/resign dialog shouldn't pause a mulitplayer game

by Michael, 10 years ago

Attachment: menu.js.v2.patch added

Now working in some more cases. Normal pause function in MP game remains untouched.

comment:4 by leper, 10 years ago

Resolution: fixed
Status: newclosed

In 14481:

Do not pause multiplayer games if one player opens a dialog. Patch by boeseRaupe. Fixes #2275.

comment:5 by leper, 10 years ago

Keywords: review removed

Thanks for the patch.

comment:6 by B. Guns, 10 years ago

Summary: [PATCH] Opening the game manual/settings/exit dialog/resign dialog shouldn't pause a mulitplayer game[PATCH] Opening the game manual/settings/exit dialog/resign dialog shouldn't pause a multiplayer game
Note: See TracTickets for help on using tickets.