Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2522 closed enhancement (fixed)

Upgrade tinygettext with STK changes

Reported by: Adrián Chaves Owned by: leper
Priority: Should Have Milestone: Alpha 19
Component: Internationalization & Localization Keywords:
Cc: Patch:

Description

The SuperTuxKart team has been improving the tinygettext library on their own repositories.

We should check the differences between the version of tinygettext that we have and the one that they use, and see if we can use theirs or implement some of their changes in ours.

Change History (14)

comment:1 by Itms, 10 years ago

Milestone: Alpha 17Alpha 18

comment:2 by Adrián Chaves, 10 years ago

Owner: set to Adrián Chaves
Status: newassigned

comment:3 by leper, 10 years ago

https://github.com/Grumbel/tinygettext/ seems like there is some upstream again.

comment:4 by leper, 10 years ago

https://github.com/Grumbel/tinygettext/pull/2 submitted our changes as a pull request to upstream.

https://github.com/Grumbel/tinygettext/issues/3 has some diffs from SuperTuxKart.

Updating to latest upstream isn't doable currently as that would require us to switch to C++11 first (#2669).

comment:5 by Adrián Chaves, 9 years ago

Owner: Adrián Chaves removed
Status: assignednew

in reply to:  4 comment:6 by historic_bruno, 9 years ago

Replying to leper:

Updating to latest upstream isn't doable currently as that would require us to switch to C++11 first (#2669).

Looks like we can do this as of r16160.

comment:7 by leper, 9 years ago

In 16168:

Update tinygettext to upstream commit ca0f3ff640. Refs #2522.

Keeps our addition of precompiled.h (r14983), win32/dirent, r15179, r15493, and r16140.

comment:8 by leper, 9 years ago

In 16169:

Add some tinygettext changes from SuperTuxKart. Refs #2522.

Move some data to RO. Pass some parameters as references.
Taken from https://github.com/Grumbel/tinygettext/issues/3.

comment:9 by leper, 9 years ago

Most of the other changes are not that useful for us (fallback support might be, but the way we add .po files might make that a bit more difficult, and there hasn't been any real reason to add it up until now).

comment:10 by leper, 9 years ago

In 16172:

Remove use of attribute that breaks the Windows build. Refs #2522.

comment:11 by Itms, 9 years ago

Milestone: Alpha 18Alpha 19

comment:12 by leper, 9 years ago

Pull request was merged.

Most of the STK changes were also included, so if we update tinygettext wecould close this ticket.

Last edited 9 years ago by leper (previous) (diff)

comment:13 by leper, 9 years ago

Owner: set to leper
Resolution: fixed
Status: newclosed

In 16462:

Update tinygettext. Fixes #2522.

Updates to upstream changeset f71a8e5e84bffadd61ac93768b332262989844fd, with some additions
that will be submitted upstream (without the addition of precompiled.h and win32 dirent).

comment:14 by leper, 9 years ago

https://github.com/tinygettext/tinygettext/pull/4 for the difference we have compared to the above changeset without the precompiled.h addition and without the win32 dirent change.

Note: See TracTickets for help on using tickets.