Make skirmish entities more mod friendly

[sanderd17]

Currently, to adapt the skirmish entities to a mod that simply adds a civ, you need to copy the skirmish entities to the mod, and adapt a line on each of them.

This breaks loading multiple mods, as they overwrite each others changes.

Instead, it would be better to define a mapping of skirmish replacements in the civ.json files, and let the skirmish replacement component get the info from there (through the player component).

[Idanwin]

I uploaded a diff, if someone could have a look at it.

[Idanwin]

cleaned up the code

[sanderd17]

Looks very good. Just watch out for your indentation. We use one extra tab per indentation level. I also wonder if it's best to work with id's, instead of the template names (you can query the template name of yourself via the templateManager).

Maybe now keep the ids equal to the template names (so include _b for the basic soldiers, someone might want to make _a and _e templates),. That would make it easier to find, and if we ever need a distinction, it's ready.

[Idanwin]

Replying to sanderd17:

Looks very good. Just watch out for your indentation. We use one extra tab per indentation level. I also wonder if it's best to work with id's, instead of the template names (you can query the template name of yourself via the templateManager).

Maybe now keep the ids equal to the template names (so include _b for the basic soldiers, someone might want to make _a and _e templates),. That would make it easier to find, and if we ever need a distinction, it's ready.

I didn't know how to query the template name (or even whether it was possible) I concur, that's a much more desirable option. I'll change it today.

[sanderd17]

In 15159:

Make skirmish entities better moddable. Fixes #2523. Patch by Idanwin.