Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2626 closed defect (fixed)

[PATCH] Bug in Simulation/Components/Formation.js

Reported by: False Vision Owned by: False Vision
Priority: Must Have Milestone: Alpha 17
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

SpiderMonkey will not call a function without a pair of parentheses. 

cmpPosition.IsInWorld; // doesnt work.
cmpPosition.IsInWorld(); // works

Patch attached.

Attachments (1)

Formation.js.patch​ (799 bytes ) - added by False Vision 10 years ago.

Download all attachments as: .zip

Change History (3)

by False Vision, 10 years ago

Attachment: Formation.js.patch​ added

comment:1 by leper, 10 years ago

Resolution: → fixed
Status: new → closed

In 15342:

Actually call the function instead of testing if it exists. Patch by falsevision. Fixes #2626.

comment:2 by leper, 10 years ago

Keywords: review removed

Thanks. Reporting such small issues on IRC (#0ad-dev on QuakeNet) before opening a ticket would be nice.

Note: See TracTickets for help on using tickets.