[PATCH] When garrisoning a hero, the selection ring is not cleared

[mimo]

The hero ring is not cleared when garrisoning it, so it stays at the last position occupied by the hero before being put out of world.

[leper]

#2911 was a duplicate of this.

[Stan]

Fix, Sorry, uploaded to wrong ticket first.

[leper]

cmpPositon can be null and you should verify that. (Not sure if this is the best place to handle this, but I haven't looked at that code for some time.

[Stan]

Should I check before the current check or at the same time is fine ?

[leper]

When you use it, but make sure to adjust the code in case it is null. (!cmpPosition || cmpPosition->IsInWorld())

[Stan]

Checks if CmpPosition is null.

[Itms]

Your patch should be made differently. Indeed, you can't request Position in Selectable's Init because the order of component creation is unknown.

In my opinion, you should fix it that way: listen to PositionChanged messages and when you receive one, if the entity has a permanent selection ring, if it is in the world, display the overlay, else remove it.

Thanks for working on it :)

[Stan]

Then I dońt know how to do it :-/

[Stan]

Another one, Thanks to trompetin17 for support

[Stan]

Another One, without handle.

[Itms]

In 16274:

Fix hero selection ring not cleared when the unit goes out of the world (when garrisoning for instance).

Patch by trompetin17, fixes #2627.

[Itms]

Thanks for the patch!

[temple]

In 21241:

Fix selection rings while garrisoning

Differential Revision: ​https://code.wildfiregames.com/D1158
Reviewed by: elexis, Itms
Refs: #2627