#2938 closed defect (fixed)
[PATCH]Add the hours to the time display
Reported by: | Itms | Owned by: | leper |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 18 |
Component: | UI & Simulation | Keywords: | simple patch |
Cc: | Patch: |
Description
As reported on the forums, the time display in the game is not properly set up to display the hours, this should be fixed.
Attachments (1)
Change History (8)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
I believe this bug should read a little differently. I have been looking into fixing it, and the hours do display, however the hour value is incorrect. For example after one hour the hour shows 08. After calling the function again on 7200000 milliseconds, it will show 09.
comment:3 by , 9 years ago
Milestone: | Backlog → Alpha 18 |
---|---|
Summary: | Add the hours to the time display → [PATCH]Add the hours to the time display |
comment:4 by , 9 years ago
Keywords: | review patch added |
---|
comment:6 by , 9 years ago
Keywords: | review removed |
---|
Thanks for the patch.
I made some slight changes to your patch:
- Tabs, not spaces (See Coding_Conventions).
- Used
getGMT()
instead of explicitly constructing that every time. - Used
std::string
as using aCStr
just to convert it back to anstd::string
is useless. - Used
%hs
instead of%s
as that causes issues on at least Windows (See Coding_Conventions).
Note:
See TracTickets
for help on using tickets.
I think this is linked to #2894: the display of the ingame time should be made consistent with the real time display.