Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2969 closed defect (fixed)

[PATCH] In Atlas, random maps also generate mirages

Reported by: AlThePhoenix Owned by: Itms
Priority: Must Have Milestone: Alpha 18
Component: Atlas editor Keywords:
Cc: Patch:

Description

Couldn't think of a very descriptive title, feel free to change it.

When generating a random map in Atlas (e.g. a normal-sized Continent map), mirages are placed, too. While still in Atlas, everything is fine until you save that map and either start the game normally and try to play the map or restart Atlas and load the map you saved before. You will be greeted by an endless chain of warnings. It seems like most of the generated mirages are trees.

		<Entity uid="6510">
			<Template>mirage|gaia/flora_tree_pine</Template>
			<Player>0</Player>
			<Position x="786.72826" z="1073.16172"/>
			<Orientation y="1.05866"/>
			<Actor seed="5300"/>
		</Entity>

Right now you can get rid of the warnings by manually editing out the mirages of the saved maps' .xml.

https://dl.dropboxusercontent.com/u/93679544/0AD%20logs/atlasmirage-interestinglog.html https://dl.dropboxusercontent.com/u/93679544/0AD%20logs/Aegean_Sea_Test_Mirages.zip

Attachments (2)

InitGame.js.patch (1.2 KB ) - added by Itms 9 years ago.
InitGame.js.2.patch (6.5 KB ) - added by Itms 9 years ago.
same patch, plus tweaks to init functions

Download all attachments as: .zip

Change History (9)

comment:1 by Itms, 9 years ago

Keywords: Atlas Mirage warning removed
Milestone: BacklogAlpha 18
Owner: set to Itms
Priority: Should HaveMust Have

I will look into it.

comment:2 by Itms, 9 years ago

Keywords: review patch added
Summary: Atlas: In Atlas, random maps also generate mirages[PATCH] In Atlas, random maps also generate mirages

by Itms, 9 years ago

Attachment: InitGame.js.patch added

by Itms, 9 years ago

Attachment: InitGame.js.2.patch added

same patch, plus tweaks to init functions

comment:3 by Itms, 9 years ago

Resolution: fixed
Status: newclosed

In 16129:

Fix the initial exploration of territories, which shouldn't be performed in Atlas.
Also clean up the code a bit.

Fixes #2969

comment:4 by Itms, 9 years ago

Keywords: review patch removed

comment:5 by mimo, 9 years ago

since 16129, skirmish entities are no more destroyed when replaced and are sent to the ai on the first turn. This must be a consequence of the move of flushDestroyedEntities from the c++ to the js.

comment:6 by Itms, 9 years ago

mimo, how can I test this and display these AI messages? So that I can work on it and see if I'm fixing anything :)

comment:7 by mimo, 9 years ago

well, I've just tried to reproduce it and could not. Sorry for the noise (I suppose my svn was messed up 3 days ago).

Note: See TracTickets for help on using tickets.