#3056 closed enhancement (fixed)
[PATCH] Some missing newlines in debug_printf
Reported by: | elexis | Owned by: | ben |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 19 |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description
Browsing the replay log, i found this:
Turn 3099 (500)... Turn 3100 (500)... HASH MISMATCH (93e39ed7f2eb363dfb152290408b7526 != 04f91bfec920d536a2c39bbac9366803)Turn 3101 (500)... Turn 3102 (500)... Turn 3103 (500)...
Its obviously missing a newline. I found a few more places where \n was missing.
Attachments (1)
Change History (7)
comment:1 by , 9 years ago
Milestone: | Alpha 18 → Alpha 19 |
---|
comment:2 by , 9 years ago
Why do you add
- else if (!name.empty())
44 + else if (!name.empty() && name.substr(0, 7) != "hotkey.")
You forgot the !
- debug_printf("Cinematic mode not found for %d !", data.m_Style);
19 + debug_printf("Cinematic mode not found for %d\n", data.m_Style);
by , 9 years ago
Attachment: | r16339_debug_printf_newlines.patch added |
---|
comment:3 by , 9 years ago
Also, not sure if you program but
--- source/ps/Replay.cpp (http://svn.wildfiregames.com/public/ps/trunk) (revision 16339)
38 +++ source/ps/Replay.cpp (working copy)
Shouldn't be modified right ?
You still forgot the ! on line 19 ;) Stan@Ticketman.
comment:4 by , 9 years ago
1- The hotkey thing was a mistake, shouldnt get into the patch, I updated it. 2- I removed the exclamation mark to make the two identical error messages consistent.
comment:6 by , 9 years ago
Keywords: | review removed |
---|
You have unrelated changes in that patch.