#3118 closed defect (fixed)
Brackets in servername cause errors in multiplayer lobby
| Reported by: | elexis | Owned by: | leper |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 19 |
| Component: | Multiplayer lobby | Keywords: | |
| Cc: | Patch: |
Description
Today and yesterday everybody that joined the a18 lobby had errors appearing:
ERROR: Invalid tag 'Fe(CN)6' at 27 in '[color="255 0 0"]K4[Fe(CN)6][/color]' ERROR: Invalid tag 'Fe(CN)6' at 10 in 'K4[Fe(CN)6]'
A quick search in wireshark for 'K4[Fe(CN)6]' reveals that someone used this string (the chemical formula for Potassium ferrocyanide) in his servername.
Reproduce: If one hosts a lobby game with brackets in the servername and joins the lobby with another account, the errors appear for that servername too.
The error is printed in gui/GUItext.cpp.
Solution: sanitize server names.
Attachments (1)
Note:
See TracTickets
for help on using tickets.
Also by adding '[color="0 0 255"]testcolor' to the servername one can change the displayed color of individual words. There are probably way more non intended things one could do here.