[PATCH] Ceasefire time GUI improvements

[leper]

Currently the remaining ceasefire time in the diplomacy screen is only displayed if the setting for the diplomacy overlay (top right corner) is active. The diplomacy screen should always display the remaining time. (See gui/common/functions_global_object.js)

Once ceasefire is over the remaining time display in the diplomacy screen should be removed. The message is either slightly wrong (ceasefire has already ended) or just plain wrong (ceasefire certainly doesn't end in 00:01 (which is probably a slight timing issue)). The hiding can possibly be done by having the simulation send a notification to the gui (which is then handled in gui/session/messages.js).

Currently we also display diplomacy notifications when ceasefire ends (which is unnecessary). We should just send a notification to the gui (as noted above) and not send the diplomacy notifications. (See simulation/components/CeasefireManager.js)

[Stan]

Should assess 1) and 3) untested.

[elexis]

Getting eight "Player X has declared war on you" messages after the ceasefire ended becomes a bit annoying. I know the change in CeasefireManager.jsis sufficient to remove the chat messages. Didn't test, but I think a call to UpdateDiplomacies or something might be needed to update the screen.

[Stan]

That fixes it for me.

[elexis]

• 1. (showing the ceasefire counter in the diplomacy menu regardless of the boolean option) and 3. (spamming the chat with up to 14 "player X has declared war on you" messages) are fixed correctly by Stan.

• 2. (hiding the ceasefire counter in the diplomacy manager after the timer ran out) was not done correctly and is fixed by the patch above.

[elexis]

The previous patch showed the ceasefire overlay counter even if the setting was disabled.

[mimo]

In 17118:

fix the ceaseFire gui, patch by elexis, fixes #3413

[mimo]

Thanks for the patch