Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3861 closed defect (fixed)

[PATCH] The Stonehenge wonder can go through other buildings

Reported by: eternaf Owned by: fatherbushido
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

As can be seen in the attached screenshot, Stonehenge can be built partially onto a wall and a storehouse.

Attachments (5)

screenshot.png (535.9 KB ) - added by eternaf 8 years ago.
round_footprint_obstruction.jpg (606.6 KB ) - added by fatherbushido 8 years ago.
3861.diff (2.0 KB ) - added by fatherbushido 8 years ago.
newobstruction.jpg (223.8 KB ) - added by fatherbushido 8 years ago.
wonderfootprints.jpg (334.5 KB ) - added by elexis 8 years ago.
Carthaginian and ptolemian wonder footprint could become slightly larger too.

Download all attachments as: .zip

Change History (12)

by eternaf, 8 years ago

Attachment: screenshot.png added

comment:1 by fatherbushido, 8 years ago

Summary: The Gauls wonder can go through other buildingsThe Brits wonder can go through other buildings

comment:2 by fatherbushido, 8 years ago

Summary: The Brits wonder can go through other buildingsThe Stonehenge wonder can go through other buildings

comment:3 by fatherbushido, 8 years ago

It's related to an inconsistency between the footprint size and the obstruction size (it seems it was introduced in r14027 when the model changed, the footprint was modified but not the obstruction size).

http://trac.wildfiregames.com/raw-attachment/ticket/3861/round_footprint_obstruction.jpg

So I suggest to fix the obstruction size (something close to (but not) inscribing the cicular footprint in the obstruction square):

http://trac.wildfiregames.com/raw-attachment/ticket/3861/newobstruction.jpg

Last edited 8 years ago by fatherbushido (previous) (diff)

by fatherbushido, 8 years ago

by fatherbushido, 8 years ago

Attachment: 3861.diff added

by fatherbushido, 8 years ago

Attachment: newobstruction.jpg added

comment:4 by fatherbushido, 8 years ago

Keywords: patch review added
Milestone: BacklogAlpha 21
Summary: The Stonehenge wonder can go through other buildings[PATCH] The Stonehenge wonder can go through other buildings

by elexis, 8 years ago

Attachment: wonderfootprints.jpg added

Carthaginian and ptolemian wonder footprint could become slightly larger too.

comment:5 by fatherbushido, 8 years ago

Owner: set to fatherbushido
Resolution: fixed
Status: newclosed

In 18837:

Tweak obstruction size of the stonehenge wonder. It seems it was not updated when the model changed. Reviewed by elexis. Fixes #3861.

comment:6 by fatherbushido, 8 years ago

Keywords: review removed

comment:7 by elexis, 8 years ago

Thanks for the patch, those few centimeters for the others wonders are not really relevant and I'm assuming other buildings have that too.

Note: See TracTickets for help on using tickets.