Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4088 closed defect (fixed)

[PATCH] Ambush:The ccs of allies are at the exact same place in 3v1

Reported by: zoro Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: Maps Keywords: patch
Cc: Patch:

Description (last modified by zoro)

3 civic centers are placed at the exact same place/get stacked into each other on the map Ambush. 2 players can not build anything because only one player has his/her own territory. I've only seen this in a 3v1 so it's proably only in games where the number of players distinguish from team to team. (you find a replay in the attachement)

Attachments (3)

ambush cc bug replay.zip (8.2 KB ) - added by zoro 8 years ago.
ambush-3-ccs-at-the-same-place.png (603.5 KB ) - added by zoro 8 years ago.
stronghold-team-placement-bug.diff (1.4 KB ) - added by _kali 8 years ago.
proposed patch for ticket #4088

Download all attachments as: .zip

Change History (10)

by zoro, 8 years ago

Attachment: ambush cc bug replay.zip added

comment:1 by zoro, 8 years ago

Description: modified (diff)

comment:2 by zoro, 8 years ago

Description: modified (diff)

by _kali, 8 years ago

proposed patch for ticket #4088

comment:3 by _kali, 8 years ago

The issue was with the stronghold team placement function. When there is a team of 1, the location of that team is set to the center of the stronghold location. However, when a team of multiple players is rendered after that team, the center starting location was being used. stronghold-team-placement-bug.diff fixes this by grabbing the original team distance variable before each team is rendered.

Testing on Ambush, Medium, seed: 9532, the bug appears as in the screenshots, and then teams are rendered correctly after the patch is applied.

comment:4 by _kali, 8 years ago

Keywords: review added

comment:5 by Stan, 8 years ago

Keywords: patch added
Summary: Ambush:The ccs of allies are at the exact same place in 3v1[PATCH] Ambush:The ccs of allies are at the exact same place in 3v1

comment:6 by elexis, 8 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18530:

Fix a stronghold placement bug. Patch by _kali, fixes #4088.

Furthermore add two TODOs about other known placement bugs and
don't enforce close player placement if the team consists of only two players,
since controlling much territory is more important than having a neighboring allied CC close by.

comment:7 by elexis, 8 years ago

Keywords: review removed
Milestone: BacklogAlpha 21

Thanks for the patch _kali!

In case you have some time sometime, those retry loops mentioned in the commit would make "Hell's Pass" way more reliable as resources are too often missing there (probably ticket somewhere).

Keep up the good work!

Also thanks to the reporter making an account just for this ticket. Hopefully it won't be the last! :)

Note: See TracTickets for help on using tickets.