#4089 closed defect (fixed)
[PATCH] Update manual for hotkeys related to idle fighters
Reported by: | Andy Alt | Owned by: | Andy Alt |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
This patches binaries/data/mods/public/gui/manual/intro.txt
The forward slash is now used to select idle fighters, and this patch reflects that change.
I've also made the change at http://trac.wildfiregames.com/wiki/HotKeys
Attachments (4)
Change History (19)
by , 8 years ago
Attachment: | intro.txt.patch added |
---|
comment:1 by , 8 years ago
Summary: | [PATCH] update for hotkeys related to idling → [PATCH] update for hotkeys related to idle fighters |
---|
comment:2 by , 8 years ago
Description: | modified (diff) |
---|
comment:3 by , 8 years ago
Component: | Non-game systems → UI & Simulation |
---|---|
Keywords: | manual hotkeys review intro.txt removed |
by , 8 years ago
Attachment: | intro.txt.2.patch added |
---|
by , 8 years ago
Attachment: | intro.txt.3.patch added |
---|
comment:4 by , 8 years ago
In the 3rd patch, I included brief instructions on how to access the interactive tutorial.
I also made a note to make it clear that clicking the "view online" button would give the user a more comprehensive guide.
Is that ok?
For future reference, the credits filename is programming.json
comment:5 by , 8 years ago
Keywords: | review added |
---|
comment:6 by , 8 years ago
No all keyboard are same, for example the actual config don't found that short in my keyboard.
comment:8 by , 8 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
@Lionkanzen, thank you for pointing this out. I have no idea how to deal with different keyboard layouts, but I would expect that I'll be discussing it more with the 0 A.D. developers.
comment:9 by , 8 years ago
The purpose of this ticket is to show the actually assigned (default) keys in that page.
It might be true that some of these keys are not present on some keyboard layouts. The user should be able to assign custom keys to the hotkeys to solve that problem (ticket somewhere).
follow-up: 11 comment:10 by , 8 years ago
Keywords: | review removed |
---|
Thanks for the patch.
Please remove the part about the introductory tutorial which is not ready for use yet, and the hint about the online version which doesn't add anything.
Also, unfortunately this can't count as a contribution to the code. If you really want to have your name in the Credits right now you can use the Miscellaneous tab, but I'm sure you will have a coding contribution in soon!
comment:11 by , 8 years ago
Replying to Itms:
Thanks for the patch.
Please remove the part about the introductory tutorial which is not ready for use yet, and the hint about the online version which doesn't add anything.
Also, unfortunately this can't count as a contribution to the code. If you really want to have your name in the Credits right now you can use the Miscellaneous tab, but I'm sure you will have a coding contribution in soon!
I added my name to the credits because I really wanted to have my name in there?
comment:12 by , 8 years ago
Keywords: | review added |
---|
comment:14 by , 8 years ago
Keywords: | review removed |
---|---|
Summary: | [PATCH] update for hotkeys related to idle fighters → [PATCH] Update manual for hotkeys related to idle fighters |
Type: | enhancement → defect |
Thanks for the patch. I see you have already updated wiki:HotKeys, that's good. (I wouldn't be surprised if there are some other deviations from the wiki / intro.txt / default.cfg, which is just the result of not having a single source of truth but slightly modified copies).
We will add your name to the programming section of the contributors list once that sound notification patch (#2898) is done (which I can assure you will be a well received feature) (or we can add it to misc.json as Itms offered otherwise).
Keep it up :)
comment:15 by , 8 years ago
elexis and Itms, thanks for the help. I'm sorry I was sarcastic with Itms instead of being more clear on what rubbed me the wrong way. I'll try to resolve things better than I did, if misunderstanding arise in the future.
As for an absolute truth, I wonder if "declaring" one of the three as an absolute truth might help, and then making it known that it is the "master" copy.
I don't think we need to worry about adding my name to misc.json. I'm content to wait until until ticket:2898 is approved. Thank you for offering to list me so soon after contributing. It's a pleasant surprise.
Patches should be complete, so this line of
Intro.txt
looks like it'd be broken then too and related to this patch:default.cfg says:
Add your name to
programmers.json
for the credits (even though you didn't actually program yet), unless you find a place in that directory that suits better.And don't add all those arbitrary keywords to tickets, we basically only use patch and review if I'm not forgetting any. Also you can abbreviate wiki entries, commits and tickets, see that wiki:WikiFormatting link.