Ticket #421 (closed task: fixed)

Opened 4 years ago

Last modified 3 years ago

Add a review request flag to Trac

Reported by: Philip Owned by:
Priority: Nice to Have Milestone:
Component: Non-game systems Keywords: review
Cc:

Description

Add a review request flag to Trac

Change History

comment:1 Changed 4 years ago by Philip

  • review_request changed from 0 to 1

How about adding the following: 

[ticket-custom]
review_request = checkbox
review_request.label = Request review of patch
review_request.value = 0

comment:2 Changed 4 years ago by Philip

  • Status changed from new to closed
  • Resolution set to fixed

Searches like this seem to work. Looks good to me.

comment:3 Changed 4 years ago by Philip

  • Status changed from closed to reopened
  • Resolution fixed deleted

Hmm, I've changed my mind. This breaks some report layouts, and introduces spurious changes when you modify an old ticket, and offers little value. Probably better to simply use a keyword like "review".

comment:4 Changed 4 years ago by Philip

  • Keywords review added

Proposed solution: remove the [ticket-custom] stuff, use keywords and searches like this.

comment:5 Changed 4 years ago by Philip

  • Status changed from reopened to closed
  • Resolution set to fixed

Looks good to me, again.

comment:6 Changed 3 years ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

Note: See TracTickets for help on using tickets.