Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#459 closed defect (fixed)

vfs_Lookup tries to create bogus directories

Reported by: Philip Taylor Owned by:
Priority: Should Have Milestone: Pre-Alpha 1
Component: Core engine Keywords:
Cc: Jan Wassenberg Patch:

Description

When I run the game on Linux (with no non-standard directories, and with a read-only root), g_VFS->Mount(L"screenshots/", paths.Data()/L"screenshots/") ends up calling vfs_Lookup which calls wmkdir("screenshots") which fails because that's relative to the cwd (the system directory) and read-only.

The ~/.local/share/0ad/screenshots/ directory is created before this happens, and it tries creating the bogus screenshots directory even if that proper one exists.

Change History (4)

comment:1 by Philip Taylor, 14 years ago

Milestone: UnclassifiedOS Pre-Alpha 1

comment:2 by Jan Wassenberg, 14 years ago

Resolution: fixed
Status: newclosed

(In [7378]) fix: mustn't create directories during mount's vfs path traversal (because they may not be associated with a directory, especially in the common case of mounting into the root directory) fixes #459

comment:3 by (none), 14 years ago

Milestone: OS Pre-Alpha 1

Milestone OS Pre-Alpha 1 deleted

comment:4 by historic_bruno, 12 years ago

Milestone: Pre-Alpha 1
Note: See TracTickets for help on using tickets.