Ticket #543 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Replace skybox with black background

Reported by: Philip Owned by: Jayschwa
Priority: Nice to Have Milestone:
Component: Core engine Keywords: review, simple
Cc:

Description

Per discussion here, it would be good to try disabling the skybox and rendering flat black when looking outside the terrain.

Water reflections should still use the skybox as normal.

See CRenderer's calls to RenderSky. I think the background colour is set by Render in GameSetup.cpp, so that should probably be changed to always set it to black.

Attachments

black_background.patch (1.2 KB) - added by Jayschwa 3 years ago.
This patch appears to have your desired effect.

Change History

Changed 3 years ago by Jayschwa

This patch appears to have your desired effect.

comment:1 Changed 3 years ago by Jayschwa

  • Owner set to Jayschwa
  • Status changed from new to assigned

Attached a patch which appears to have the desired effect. RenderSky? is called twice, once for reflections and once for the player's viewpoint. Removing the call for the player's viewpoint renders the background a solid color while keeping pretty clouds in the water reflection.

comment:2 Changed 3 years ago by Jayschwa

  • Keywords review, added

comment:3 Changed 3 years ago by Philip

Thanks! Seems to work fine for me. I just changed it a little bit to get the black from the .cfg file instead of from the code, since we already had that config code and we might as well use it.

comment:4 Changed 3 years ago by philip

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [8018]) Fix #543 (Replace skybox with black background), based on patch from Jayschwa

comment:5 Changed 3 years ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

Note: See TracTickets for help on using tickets.