Opened 14 years ago

Closed 14 years ago

Last modified 8 years ago

#543 closed task (fixed)

Replace skybox with black background

Reported by: Philip Taylor Owned by: Jay Weisskopf
Priority: Nice to Have Milestone:
Component: Core engine Keywords: simple
Cc: Patch:

Description

Per discussion here, it would be good to try disabling the skybox and rendering flat black when looking outside the terrain.

Water reflections should still use the skybox as normal.

See CRenderer's calls to RenderSky. I think the background colour is set by Render in GameSetup.cpp, so that should probably be changed to always set it to black.

Attachments (1)

black_background.patch (1.2 KB ) - added by Jay Weisskopf 14 years ago.
This patch appears to have your desired effect.

Download all attachments as: .zip

Change History (7)

by Jay Weisskopf, 14 years ago

Attachment: black_background.patch added

This patch appears to have your desired effect.

comment:1 by Jay Weisskopf, 14 years ago

Owner: set to Jay Weisskopf
Status: newassigned

Attached a patch which appears to have the desired effect. RenderSky is called twice, once for reflections and once for the player's viewpoint. Removing the call for the player's viewpoint renders the background a solid color while keeping pretty clouds in the water reflection.

comment:2 by Jay Weisskopf, 14 years ago

Keywords: review added

comment:3 by Philip Taylor, 14 years ago

Thanks! Seems to work fine for me. I just changed it a little bit to get the black from the .cfg file instead of from the code, since we already had that config code and we might as well use it.

comment:4 by philip, 14 years ago

Resolution: fixed
Status: assignedclosed

(In [8018]) Fix #543 (Replace skybox with black background), based on patch from Jayschwa

comment:5 by (none), 14 years ago

Milestone: Unclassified

Milestone Unclassified deleted

comment:6 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.