Opened 14 years ago

Closed 13 years ago

Last modified 8 years ago

#591 closed defect (fixed)

[PATCH] Disable sounds for units in FoW/SoD

Reported by: Philip Taylor Owned by:
Priority: Should Have Milestone: Alpha 4
Component: Core engine Keywords: simple, fow
Cc: Patch:

Description

If an enemy unit is in fog-of-war/shroud-of-darkness areas, you shouldn't be able to hear them.

This could probably be handled by making CCmpSoundManager::PlaySoundGroup detect if the source entity is visible to the current player (see e.g. CCmpVisualActor::Interpolate using ICmpRangeManager::GetLosVisibility) and then ignoring the sound if not.

Attachments (1)

BugFix#591.patch (1.4 KB ) - added by Bogdan Lazic 13 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by Andrew, 14 years ago

Cc: Philip Taylor added

comment:2 by Andrew, 14 years ago

Cc: Philip Taylor removed
Owner: set to Philip Taylor

comment:3 by Andrew, 14 years ago

Milestone: UnclassifiedOS Alpha 2

comment:4 by Kieran P, 14 years ago

Milestone: OS Alpha 2OS Alpha 3

Pushing back to Alpha 3 due to time constraints and complexity.

comment:5 by Kieran P, 14 years ago

Priority: minormajor

comment:6 by Kieran P, 13 years ago

Type: taskdefect

comment:7 by Kieran P, 13 years ago

Milestone: Alpha 3Alpha 4

comment:8 by Kieran P, 13 years ago

Owner: Philip Taylor removed

by Bogdan Lazic, 13 years ago

Attachment: BugFix#591.patch added

comment:9 by Bogdan Lazic, 13 years ago

Keywords: review added

Bug is fixed based on description.

comment:10 by Kieran P, 13 years ago

Summary: Disable sounds for units in FoW/SoD[PATCH] Disable sounds for units in FoW/SoD

comment:11 by Philip Taylor, 13 years ago

Thanks, looks good to me. (I've just rearranged the comments a little bit.)

comment:12 by philip, 13 years ago

Resolution: fixed
Status: newclosed

(In [8910]) Fix #591 (Disable sounds for units in FoW/SoD), based on patch from Bogi

comment:13 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.