Template viewer for mace storehouse tech displays wrong time

[Langbart]

reported by 0ad is the best rts game in the forum: ​Game guide of Macedonians error reporting (24/Dec/22)

Macedonian has warehouse technology - 100% of the study time. However, when the player clicks on "Learn Game > Structure > Warehouse (right mouse button)" or clicks on the right mouse button of the warehouse in the game, it shows the cost time. This may confuse the player.

bisect

• likley introduced with the introduction of the new civbonus for the Macedonians in [26627]

related ticket

• #6587 (10/Jul/22)

possible solution ?

binaries/data/mods/public/gui/reference/viewer/ViewerPage.js

@@ -76 +76 @@
 
             let researchers = templateLists.techs.get(currentTemplateName);
             if (researchers && researchers.length)
+            {
                 this.currentTemplate.researchedByListOfNames = researchers.map(researcher => getEntityNames(this.TemplateParser.getEntity(researcher, this.activeCiv)));
+
+                const {techCostMultiplier} = this.TemplateParser.getEntity(researchers[0], this.activeCiv);
+                for (const res in this.currentTemplate.cost)
+                    if (this.currentTemplate.cost[res])
+                        this.currentTemplate.cost[res] *= techCostMultiplier[res];
+            }
         }
 
         if (this.currentTemplate.builder && this.currentTemplate.builder.length)

[Langbart]

Minimize the diff from the possible solution section

[Langbart]

braces

[Freagarach]

In 27454:

Fix Mace storehouse tech time in template viewer.

Reported at ​https://wildfiregames.com/forum/topic/102542-game-guide-of-macedonians-error-reporting
Patch by: @Langbart
Fixes #6691
Refs. #6587