Opened 13 years ago
Closed 13 years ago
#790 closed defect (fixed)
Sound effects have stopped working
| Reported by: | Kieran P | Owned by: | Philip Taylor |
|---|---|---|---|
| Priority: | Release Blocker | Milestone: | Alpha 5 |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: |
Description
See http://www.wildfiregames.com/forum/index.php?showtopic=14595
They used to work in Alpha 4, now they don't in Alpha 5. We can't release with a regression!
Change History (2)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In CCmpSoundManager::PlaySoundGroup, we check if the entity is visible before playing the sound. But for some reason UnitAnimation is calling that with entity ID 0 (INVALID_ENTITY), which is never visible, so the sound never plays. (Maybe this has to do with [9055], I notice the UnitAnimation constructor changed?) Probably we should be checking for INVALID_ENTITY and throwing an error so these silent failures can't happen :/
Hope that helps.