Ticket #887 (closed enhancement: wontfix)

Opened 2 years ago

Last modified 2 years ago

[PATCH] Catch terrain patch vertex height for water rendering

Reported by: kromxp Owned by: philip
Priority: Should Have Milestone: Alpha 7
Component: Core engine Keywords: patch, review
Cc:

Description

The proposed small patch catches the vertex heights of the patches used.

When rendering water if there is not any vertex below water level, the whole patch is skipped. For the patches that are shown, their height levels are cached and faster to access.

It also fixes the // TODO: stop using g_Game

An improvement by using this patch could be to only call the TerrainRenderer::RenderWater if any of the patches has been submitted to be rendered with any vertex below water level.

Attachments

catch-patch-vertex-height.patch​ (4.4 KB) - added by kromxp 2 years ago.

Change History

Changed 2 years ago by kromxp

comment:1 Changed 2 years ago by k776

  • Milestone changed from Alpha 6 to Alpha 7

comment:2 Changed 2 years ago by k776

  • Owner set to kromxp

comment:3 Changed 2 years ago by k776

  • Keywords patch, added

comment:4 Changed 2 years ago by k776

  • Owner changed from kromxp to philip

Work is included in or made obsolete by eihrul_'s frakenpatch. See ​http://lee.fov120.com/0ad-frankenpatch.diff . Ticket will be closed once frankenpatch is reviewed and committed.

comment:5 Changed 2 years ago by Philip

  • Status changed from new to closed
  • Resolution set to wontfix

r9814 changes the water renderer so I don't think this is needed any more.

Note: See TracTickets for help on using tickets.