Opened 11 years ago

Closed 10 years ago

#2185 closed defect (fixed)

[PATCH] Fixes for user-visible strings

Reported by: Adrián Chaves Owned by:
Priority: Should Have Milestone: Alpha 15
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by Adrián Chaves)

These include wrong caps and usage of British English instead of American English, as well as straight typos, removal of BOM, etc.

Attachments (7)

randomMapsSpelling.patch​ (33.9 KB ) - added by Adrián Chaves 11 years ago.
Typo fixes.
civilizationTypos.patch​ (17.6 KB ) - added by Adrián Chaves 11 years ago.
Typos in the civilizations folder.
introChanges.patch​ (6.1 KB ) - added by Adrián Chaves 11 years ago.
Changes to the manual.
technologiesFixes.patch​ (19.6 KB ) - added by Adrián Chaves 11 years ago.
Typos and BOM removal for technology description files.
templateFixes.patch​ (82.4 KB ) - added by Adrián Chaves 11 years ago.
Typo fixes for entities.
unixLineEndsForTips.patch​ (20.4 KB ) - added by Adrián Chaves 11 years ago.
removeUselessSpacesFromSplashscreenText.patch​ (974 bytes ) - added by Adrián Chaves 11 years ago.

Download all attachments as: .zip

Change History (19)

by Adrián Chaves, 11 years ago

Attachment: randomMapsSpelling.patch​ added

Typo fixes.

comment:1 by Adrián Chaves, 11 years ago

Summary: [PATCH] Misspell fixes for random maps → [PATCH] Misspellings

by Adrián Chaves, 11 years ago

Attachment: civilizationTypos.patch​ added

Typos in the civilizations folder.

by Adrián Chaves, 11 years ago

Attachment: introChanges.patch​ added

Changes to the manual.

by Adrián Chaves, 11 years ago

Attachment: technologiesFixes.patch​ added

Typos and BOM removal for technology description files.

by Adrián Chaves, 11 years ago

Attachment: templateFixes.patch​ added

Typo fixes for entities.

comment:2 by historic_bruno, 11 years ago

Some of the typo fixes introduce new typos ;)

Honestly, a lot of the history sections aren't well written, they have awkward and incorrect grammar. Reviewing this patch, I'm finding 5x as many errors as it fixes. If we really want them to be correct, they will need rewriting from scratch or at least careful proofreading. This is one of the reasons why we have delayed translation work on the game, it's annoying to make minor corrections to existing text that we know eventually needs to be rewritten.

comment:3 by Adrián Chaves, 11 years ago

Well, translations are already here, so you are more than welcome to rewrite from scratch anything that needs to :)

comment:4 by Adrián Chaves, 11 years ago

Description: modified (diff)
Summary: [PATCH] Misspellings → [PATCH] Fixes for user-visible strings

by Adrián Chaves, 11 years ago

Attachment: unixLineEndsForTips.patch​ added

by Adrián Chaves, 11 years ago

Attachment: removeUselessSpacesFromSplashscreenText.patch​ added

comment:5 by leper, 11 years ago

In 14028:

Line endings. Refs #2185.

comment:6 by leper, 11 years ago

In 14029:

Fix typos, remove BOMs and add newlines before EOF. Refs #2185. Patch by Gallaecio.

comment:7 by leper, 11 years ago

In 14037:

Remove inconsistencies in the manual. Refs #2185.
Fix player name.
Make log messages when saving games use quotes around paths.

comment:8 by leper, 11 years ago

I committed introChanges.patch (without the dialogs -> dialog boxes change; that didn't sound that much better IMO), technologyFixes.patch and unixLineEndsForTips.patch (or rather I set the svn property for line endings on that one).

comment:9 by gallaecio, 10 years ago

In 14053:

Fix typos in descriptions of random maps. Refs #2185.

comment:10 by gallaecio, 10 years ago

In 14054:

Fix typos in civilization files. Refs #2185.

comment:11 by gallaecio, 10 years ago

In 14055:

Fix typos in template files. Refs #2185.

comment:12 by Adrián Chaves, 10 years ago

Keywords: review removed
Resolution: → fixed
Status: new → closed

Applied all changes but the removal of spaces in the fundraiser file, as those were indeed intended for formatting.

Note: See TracTickets for help on using tickets.