Opened 10 years ago
Closed 9 years ago
#2908 closed defect (fixed)
[PATCH] Use short pathfinder update when colliding with entities
Reported by: | ickylevel | Owned by: | Itms |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 19 |
Component: | UI & Simulation | Keywords: | patch pathfinding |
Cc: | tjh.hts@…, bgamari@… | Patch: |
Description
The patch is not the final one, the code will have to be made cleaner. It's just here for testing purpose.
Instead of recalculating everything when a unit hits another entity, the pathfinder will just update the short range path, improving performance. The calculation is done immediately as opposed to the 'next' turn. This has to be checked and verified in multiplayer.
Attachments (2)
Change History (12)
by , 10 years ago
Attachment: | pathfix.patch added |
---|
comment:1 by , 10 years ago
Keywords: | patch review added |
---|
comment:3 by , 10 years ago
I haven't tried to queue it so I could try and see if it increase further the framerate.
by , 10 years ago
Attachment: | pathfix_async.patch added |
---|
comment:4 by , 10 years ago
I just added pathfix_async which is the turn based version of it. It doesn't seem to do much of a difference (I am comparing using a save).
comment:5 by , 10 years ago
Cc: | added |
---|
comment:6 by , 10 years ago
Cc: | added |
---|
comment:7 by , 9 years ago
Keywords: | review removed |
---|
This change is obsolete considering the changes performed in Philip's patch (something rather similar was done there).
So I'm not going to close the ticket as invalid, I'll mark it as fixed when the pathfinding branch is merged.
Thanks for working on it anyways!
comment:8 by , 9 years ago
Keywords: | pathfinding added |
---|
comment:9 by , 9 years ago
Milestone: | Alpha 18 → Alpha 19 |
---|
Replying to ickylevel:
This actually sounds like it could be quite bad for performance, because instead of having that turn "buffer" before a recalculation, it happens immediately. Just imagine how often that could happen with a large group of units moving in a battle, or a unit that's trapped. This is more or less what happened the last time such a change was made (for the long pathfinder to make it more "responsive", and it's still in SVN).