[PATCH] Pressing escape shouldn't quit the server after defeat / victory

[elexis]

If a player was defeated (or won the game) a message box appears asking "Do you want to quit?". If one presses escape, the player will leave. It shoudln't leave but only close the popup box.

This is bad in particular if only the host was defeated and unintentionally closes the game while everybody else was still playing.

In the current implementation, hitting the escape button is equivalent to pushing the last button in the message box. Thats why changing the order of buttons helps with this particular issue.

It would be great to add more hotkeys, so all message boxes can be handled with the keyboard only (for example deleting units).

[elexis]

Corrects the order of the buttons in all message boxes that had it wrong.

[Itms]

We had a discussion around A17, I think, about the Yes/No button placement and we switched some without a real general agreement. So we should discuss this before committing this patch.

I personally think this is a good way to go. Quitting on "Escape" is really bad for usability.

[historic_bruno]

IIRC the decision was to use Windows' conventional button order (which I agree with), but the change was only partially implemented, and the UI work in general stalled.

[historic_bruno]

Replying to historic_bruno:

IIRC the decision was to use Windows' conventional button order (which I agree with), but the change was only partially implemented, and the UI work in general stalled.

I was remembering an earlier iteration, apparently the most recent change was the opposite of Windows (OK/Yes on the right, Cancel/No on the left).

[historic_bruno]

Replying to elexis:

In the current implementation, hitting the escape button is equivalent to pushing the last button in the message box. Thats why changing the order of buttons helps with this particular issue.

That behavior would make sense if the cancel button was on the right (it may have been when the code was written), but most of our dialogs have it on the left now, it's easier to change the "cancel" handling to use the leftmost button and fix the ~3 inconsistent dialogs.

[ben]

In 16736:

Fixes button order consistency in a few places: resign confirmation, manual, splashscreen, fixes #2837. NOTE: the convention is Cancel/Back button on the left, other action buttons are to the right. Please report any you find that don't match that!
Adds hotkey.cancel mapped to the Escape key, which is now used for closing/canceling in-game dialogs, fixes #2636, #3200. Please report any dialogs where Esc doesn't work!