'Infinite loop' of sorts in UnitAI+guarding

[Freagarach]

"INDIVIDUAL.GuardedAttacked' pushes an order to the front when the guarded entity is attacked.

Unfortunately, that completely fails to account for infinite loops.

As such, an infinite number of orders can be added over sufficient # of turns, which can end up crashing the stack.

[Freagarach]

r25175

[wraitii]

I'm not entirely sure how the entity ends up unable to move in your OG replay, but the core of the bug is easily reproducible: guard a building under attack. Many redundant 'Repair' orders are pushed to the front.

[wraitii]

more minimal repro (doesn't crash though)

[Freagarach]

So basically a duplicate of #6007?

[wraitii]

I don't think so, if I understand correctly 6007 is about multiple guards doing complex computations; The issue here is that a single unit gets thousands of orders.

[Freagarach]

Nah, the issue in 6007 is multiple entities getting hunderds of messages, thus push order fronts ;)