Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1255 closed defect (fixed)

[PATCH] Wrong units move if the same number of units is selected

Reported by: Евгений Owned by: Jonathan Waller
Priority: Should Have Milestone: Alpha 10
Component: UI & Simulation Keywords:
Cc: Patch:

Description

I select two units and make them move. While they move, i select one of this units and another one, and make them move. In this case, will move those units, which I originally select. This happens only while the units are moved. And the number of newly selected units is the same as before.

Game version: Alpha 9 Ides of March. My PC: Windows 7 Ultimate, 64-bit (Service Pack 1), AMD Phenom(tm) 9850 Quad-Core Processor 2.49 GHz, GeForce GTX 260 (driver version 295.73), (two monitors 1920x1200, 1440x900), 4 Gb RAM.

Attachments (1)

#1255-2012-03-28.patch (1.3 KB ) - added by leper 12 years ago.
If we have a unit that isn't part of a formation add a placeholder to ids.

Download all attachments as: .zip

Change History (4)

comment:1 by leper, 12 years ago

Keywords: patch review added; select order removed
Milestone: BacklogAlpha 10
Summary: the wrong units do order[PATCH] Wrong units move if the same number of units is selected

Thanks for reporting this. It was pretty easy to catch once you know how to reproduce it.

by leper, 12 years ago

Attachment: #1255-2012-03-28.patch added

If we have a unit that isn't part of a formation add a placeholder to ids.

comment:2 by Jonathan Waller, 12 years ago

Owner: set to Jonathan Waller
Resolution: fixed
Status: newclosed

In 11410:

Correctly check whether an existing formation controller can be reused. Fixes #1255.

in reply to:  1 comment:3 by Jonathan Waller, 12 years ago

Keywords: patch review removed

Thanks for your patch. In this case I felt it was cleaner to fix the issue slightly differently, rather than putting null values into an array of formation id's.

Note: See TracTickets for help on using tickets.