Opened 10 years ago
Closed 4 years ago
#2524 closed task (fixed)
Clean obsolete / broken art files
Reported by: | historic_bruno | Owned by: | enrique |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 24 |
Component: | Art & Animation | Keywords: | |
Cc: | Niek, enrique, Stan, Johnathan Good | Patch: |
Description
This is more of a long term task: basically the art folders are a mess. A lot of broken old files have been left behind and forgotten over time. Using the checkrefs.pl script, we can find many of them, but we have to be careful to interpret its results since it's not perfect. It's not something to be rushed and it can't really be automated either.
Attachments (9)
Change History (63)
comment:1 by , 10 years ago
follow-up: 4 comment:2 by , 10 years ago
I wonder if we should actually delete those old art files, or what the criteria should be to delete them.
Some might be unused in the main game, but still serve as actor in some maps.
Could we compose a list of clear criteria to mark files for deletion?
comment:3 by , 10 years ago
There are some obj files also which is a format like dae which doesńt support animations I believe best Would be not to delete them but to move them in the art part of the source that was created not long ago.
comment:4 by , 10 years ago
Replying to sanderd17:
I wonder if we should actually delete those old art files, or what the criteria should be to delete them.
Some might be unused in the main game, but still serve as actor in some maps.
Could we compose a list of clear criteria to mark files for deletion?
My criteria for deletion are pretty simple :)
- If the actor hasn't been altered in years and has been replaced with a better version (see: all Roman structures, Greek ships, etc.)
- If the actor is broken (missing props, textures, or meshes) and has a working replacement
I think all the above list meet those criteria. Actually, the checkrefs script looks for missing actors in scenarios; I will update it for skirmish maps, too.
by , 10 years ago
Attachment: | brokenactors.patch added |
---|
comment:6 by , 10 years ago
Keywords: | review added |
---|
Missing Textures
temp/temple_test.xml
palm_e.xml
palm_d.xml
grass1.xml
rome_helmet_b.xml
cliff_face_desert.xml
selection_infantry.xml
romans/civic_house.xml
Missing meshes
crannog_rocks.xml
Missing props
iberian_buckler_adv_reverse_back.xml (missing prop point)
elephant_archer(Not used missing prop point)
I also add a patch to fix the fireraiser
comment:7 by , 10 years ago
Also campaign_curtainwall_hele.obj
helmet_obj.obj should be moved to the art source, cause they are not used by the game.
comment:9 by , 9 years ago
Keywords: | patch added |
---|---|
Owner: | set to |
Summary: | Clean obsolete / broken art files → [PATCH] Clean obsolete / broken art files |
Patch from 13 month ago is still accurate.
comment:10 by , 9 years ago
Milestone: | Backlog → Alpha 20 |
---|
comment:12 by , 9 years ago
Status: | new → assigned |
---|
comment:15 by , 8 years ago
Keywords: | review patch removed |
---|---|
Milestone: | Alpha 20 → Backlog |
I think that fireraiser patch is not really relevant. It is probably part of some more files to remove, but I think we'd need an automated way to perform the task and/or a big cleanup and reorganization of the art/
files.
comment:16 by , 8 years ago
Well I just intended to fix it so it doesn't display errors :)
IIRC there are also *obj files in the art folder, which are not AFAIK recognized by the game and should be deleted.
comment:18 by , 8 years ago
Summary: | [PATCH] Clean obsolete / broken art files → Clean obsolete / broken art files |
---|
comment:19 by , 8 years ago
Cc: | added |
---|---|
Keywords: | rfc patch added |
Milestone: | Backlog → Alpha 21 |
Summary: | Clean obsolete / broken art files → [PATCH] Clean obsolete / broken art files |
comment:20 by , 8 years ago
Keywords: | review added; rfc removed |
---|
Latest patch looks fine on my end :)
comment:21 by , 8 years ago
@stanislas69:
- where should we add
wrld_med_plant.png
? - there is still :
Missing file 'art/meshes/temp/plac_helmet_e.dae' referenced by: 'public/art/actors/props/units/heads/rome_helmet_b.xml'
I hope it will fix ERROR: CCacheLoader failed to find archived or source file for: ""
(see #3796)
comment:22 by , 8 years ago
@fatherbushido: the location of the image is mentioned in the patch file
comment:23 by , 8 years ago
Well, it seems it doesn't break anything. Don't forget to delete public/art/actors/props/units/heads/rome_helmet_b.xml too.
comment:24 by , 8 years ago
The entire unused wheat theme had been removed in r18633 (so the uploaded patch was incomplete and that part can be removed from the patch).
comment:26 by , 8 years ago
Keywords: | patch review removed |
---|---|
Milestone: | Alpha 21 → Backlog |
Summary: | [PATCH] Clean obsolete / broken art files → Clean obsolete / broken art files |
Thanks for the new batch of fixes :)
comment:27 by , 7 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:28 by , 7 years ago
I have also Missing file 'art/textures/skins/structural/ao/gaul_storehouse_ao.png' referenced by: 'public/art/actors/props/structures/gauls/storehouse_barrel_b.xml', 'public/art/actors/structures/gauls/storehouse.xml'
detected by the perl script in sources/tools
comment:30 by , 7 years ago
Thanks stanislas69, can you explain me what was broken? (so perhaps I could review that).
comment:31 by , 7 years ago
The file used an incorrect AO file.
So there was
Base mesh ao -> wrong
Variant A ao -> good
Variant B ao -> good
So I removed the first one as it's not used (and doesn't exist), as it's overwritten by the files in the variants.
comment:33 by , 7 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I still have
Missing file 'art/textures/skins/structural/ao/gaul_storehouse_ao.png' referenced by: 'public/art/actors/structures/gauls/storehouse.xml'
by , 7 years ago
Attachment: | gaul_storehouse_ao_fix.diff added |
---|
Same issue as above fixed by the following patch.
comment:34 by , 7 years ago
Cc: | added |
---|---|
Keywords: | rfc patch added |
comment:35 by , 7 years ago
Keywords: | review added; rfc removed |
---|
comment:36 by , 7 years ago
New ones:
Missing file 'art/actors/props/units/heads/new/head_vercingentorix.xml' referenced by: 'public/art/actors/units/celts/vercingetorix.xml'
Missing file 'art/textures/skins/skeletal/imp_cavalry_javelinist_1.png' referenced by: 'public/art/actors/props/units/imp_scorpio_operator.xml', 'public/art/actors/props/units/imp_scorpio_packed_r.xml'
Missing file 'art/textures/skins/skeletal/imp_infantry_swordsman_b_spec.png' referenced by: 'public/art/actors/props/units/imp_scorpio_operator.xml', 'public/art/actors/props/units/imp_scorpio_packed_r.xml'
Missing file 'art/textures/skins/structural/ao/gaul_storehouse_ao.png' referenced by: 'public/art/actors/structures/gauls/storehouse.xml'
follow-up: 38 comment:37 by , 7 years ago
by , 7 years ago
Attachment: | Vercingetorix+GaulStorehouse.patch added |
---|
Fix the warning of the missing head, and the one of the unused, missing AO for the gaul storehouse.
by , 7 years ago
Attachment: | imp_cavalry_javelinist_1.png added |
---|
Fix the warning for imp Javelinist, (missing texture from delenda est)
by , 7 years ago
Attachment: | imp_infantry_swordsman_b_spec.png added |
---|
Fix the warning for imp imp_scorpio_operator, (missing texture from delenda est)
comment:38 by , 7 years ago
Replying to fatherbushido:
stanislas: can you look at those new ones introduced in r19095 (see #4440)
Done. Note that the gaul ao fix in the last patch was already in the previous one.
comment:40 by , 7 years ago
Thanks for fixing that!
Now I have that:
Missing file 'art/actors/props/structures/carthaginians/market.xml' referenced by: 'public/art/actors/structures/carthaginians/market.xml', 'public/art/actors/structures/carthaginians/market_old.xml'
Missing file 'art/actors/structures/template_structure_defense_wall_long.xml' referenced by: 'public/simulation/templates/skirmish/structures/default_wall_gate.xml', 'public/simulation/templates/skirmish/structures/iber_wall_gate.xml', 'public/simulation/templates/structures/athen_wall_gate.xml', 'public/simulation/templates/structures/brit_wall_gate.xml', 'public/simulation/templates/structures/cart_wall_gate.xml', 'public/simulation/templates/structures/gaul_wall_gate.xml', 'public/simulation/templates/structures/iber_wall_gate.xml', 'public/simulation/templates/structures/mace_wall_gate.xml', 'public/simulation/templates/structures/maur_wall_gate.xml', 'public/simulation/templates/structures/pers_wall_gate.xml', 'public/simulation/templates/structures/ptol_wall_gate.xml', 'public/simulation/templates/structures/rome_siege_wall_gate.xml', 'public/simulation/templates/structures/rome_wall_gate.xml', 'public/simulation/templates/structures/sele_wall_gate.xml', 'public/simulation/templates/structures/spart_wall_gate.xml'
by , 7 years ago
Attachment: | CartMarket+WallFix.patch added |
---|
Fix the cart market by removing a wrong prop in the death variant, the old market by updating the death variant to use market_old instead of market, and the gate main template, even though you can't build gates, to use the actor file instead of the template one.
comment:41 by , 7 years ago
Cc: | added; removed |
---|
comment:44 by , 7 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Leaving it open just in case - not sure if there's more missing references in this ticket pending
comment:45 by , 7 years ago
Keywords: | review removed |
---|
comment:46 by , 7 years ago
(At rev 19355)
Missing file 'art/actors/props/structures/hellenes/fortress_props.xml' referenced by: 'public/art/actors/special/old/athenian_fortress.xml', 'public/art/actors/special/old/athenian_fortress.xml'
Missing file 'art/textures/ui/session/portraits/' referenced by: 'public/simulation/templates/special_filter/mirage.xml'
The second one is perhaps a false alert (the perl script needs perhaps to be update to filter templates)
comment:49 by , 7 years ago
Missing file 'art/textures/skins/props/helmet/hele_themistocles.dds' referenced by: 'public/art/actors/props/units/heads/celt_viridomarus.xml'
(tested at 19942)
comment:54 by , 4 years ago
Keywords: | patch removed |
---|---|
Milestone: | Backlog → Alpha 24 |
Resolution: | → fixed |
Status: | reopened → closed |
Most of the work is done, there are no obvious warnings anymore.
I don't want to commit this yet because it's so close to A16 release, but here is the first batch for deletion. These are mostly ugly old actors that have missing textures and have been replaced by nicer newer ones. None of these files are used in the game.