Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2876 closed defect (fixed)

[PATCH] Celt tower has a misleading unit in it

Reported by: fabio Owned by: Stan
Priority: If Time Permits Milestone: Alpha 18
Component: Art & Animation Keywords:
Cc: Patch:

Description

Celt tower is the only tower showing a unit inside it, this may misleads to think it is garrisoned by a unit. Sample image:

https://i.imgur.com/4cLpcqf.png

Attachments (3)

fix_no_unit.diff (608 bytes ) - added by Stan 9 years ago.
Fix_Garisonned.diff (1.3 KB ) - added by Stan 9 years ago.
2876.2.patch (1.6 KB ) - added by Stan 9 years ago.
Fix the garrisonning point in the dae.

Download all attachments as: .zip

Change History (21)

comment:1 by Stan, 10 years ago

What do you suggest ? Removing it & adding the ability to garrison one ?

comment:2 by fabio, 10 years ago

Probably the best choice is to use a model without any support for inner unit, there is already another celt tower that has the top covered. This way all towers are consistent in their appearing leading to no possible misleadings. This is especially worth now that walls have the ability to garrison units that appears in a similar way as in this celt tower.

comment:3 by Stan, 10 years ago

I'll ask Enrique about it though I think we should use the engine as much as possible.

comment:4 by Enrique, 10 years ago

I agree with Fabio here. Now with units showing when garrisoned on walls, this could lead to confusion easily. I'll keep the tower version with the unit when garrisoned and leave it empty when ungarrisoned.

Last edited 10 years ago by Enrique (previous) (diff)

comment:5 by enrique, 10 years ago

Owner: set to enrique
Resolution: fixed
Status: newclosed

In 15876:

Prevents gaul defense_tower_a from showing a unit when not garrisoned. Fixes #2876

comment:6 by Stan, 10 years ago

As a fighting unit or a prop ? 

comment:7 by fabio, 10 years ago

Thanks for the udpate, I would prefer anyway to disable the inner unit for a copule reasons:

  • it may still be misleading since it's not consistent with all the other towers, including the other celt version, which doesn't have this behaviour;
  • the shown soldier is always the same and doesn't reflect the unit in it, that can also be a woman.

comment:8 by Stan, 10 years ago

Milestone: BacklogAlpha 18

comment:9 by fabio, 10 years ago

Resolution: fixed
Status: closedreopened

comment:10 by Jaison, 9 years ago

@enrique: Work you currently on this defect?

by Stan, 9 years ago

Attachment: fix_no_unit.diff added

by Stan, 9 years ago

Attachment: Fix_Garisonned.diff added

comment:11 by Stan, 9 years ago

Keywords: review patch added
Owner: changed from enrique to Stan
Status: reopenednew

The first fix remove the unit.

The second fix attached add a visible garisonning for the tower like this http://i.imgur.com/GDFQyhP.jpg

comment:12 by Stan, 9 years ago

Summary: Celt tower has a misleading unit in it[PATCH] Celt tower has a misleading unit in it

comment:13 by fabio, 9 years ago

I think the best approach here is either to remove this tower variant, or modify the variant closing the empty room on the top. This way it will be consistent with all other towers. A quick fix would just to leave the room always empty even when garrisoned units are inside.

comment:14 by Stan, 9 years ago

Well 1. needs Enrique approval, and you'll need to ask him.

  1. Is no unit patch.

comment:16 by Itms, 9 years ago

I agree with fabio, we need to remove entirely this unit in the tower. Also no need to have Enrique's approval IMO because it is a gameplay decision, not an artistic one.

However, the current fix_no_unit patch only removes the unit and doesn't remove the useless attachpoint from the tower model. Stan, could you take care of that and propose an updated patch? Thanks for working on it. :-)

by Stan, 9 years ago

Attachment: 2876.2.patch added

Fix the garrisonning point in the dae.

comment:17 by Itms, 9 years ago

Resolution: fixed
Status: newclosed

In 16268:

Remove entirely the unit in the Celt outpost. Also clean out the dae model to remove the associated prop point.

Fix by stanislas69, fixes #2876.

comment:18 by Itms, 9 years ago

Keywords: review patch removed

Thanks for taking care of the issue!

Note: See TracTickets for help on using tickets.