#3209 closed defect (fixed)
[PATCH] Changing the map shouldn't reset the victory condition without a reason
Reported by: | elexis | Owned by: | Itms |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 19 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description
If you anticipate playing a wonder game and change the map, the victory condition will be set to conquest back again. Often it won't be noticed until the wonder is built.
I see that not all maps might support alternative victory conditions. However if wonder mode is supported, the victory condition shouldn't be reset to conquest after changing a map. The other settings like population capacity are not reset either.
Attachments (2)
Change History (10)
comment:2 by , 9 years ago
Keywords: | patch review added; simple removed |
---|---|
Milestone: | Backlog → Alpha 19 |
Priority: | Nice to Have → Should Have |
Summary: | Changing the map shouldn't reset the victory condition → [PATCH] Changing the map shouldn't reset the victory condition |
by , 9 years ago
Attachment: | t3209_keep_victory_condition.patch added |
---|
comment:3 by , 9 years ago
This patch changes the following things in that order:
Beautifies code: (1) changes a method name from loadGameAttributes to loadPersistMatchSettings for better reading (2) rearranges the order of settings loaded, to correlate with the order of the settings in the gamesetup
Changes gamesetup: (3) Victory condition is now handled by persist match settings too (4) Victory condition won't be reset when changing the map
comment:4 by , 9 years ago
Summary: | [PATCH] Changing the map shouldn't reset the victory condition → [PATCH] Changing the map shouldn't reset the victory condition without a reason |
---|
L751-756
are not needed since the victory condition is already handled by the persist match settings, the lines don't hurt though.
The removal of L980-984
is the relevant part. The rest are beautifications. Let me give you two reasons for the need of a patch:
(1) People have noted on IRC that reseting the victory condition makes sense, since not all maps might support all victory conditions. However the set of selectable victory conditions doesn't change, so changing the selected value has no use at all.
(2) Changing the random map resets the victory condition, but no other settings, in particular: -population capactiy -starting resources -revealed / explored map -map size -number of players & selected civilizations -ceasefire time
Therefore this behaviour is really unexpected and since all settings are persisted, you assume that the victory condition is also the same as with the previously selected map. If you don't know that bug, chances are that you start the game with the wrong setting. Displaying the victory condition ingame (see #3209) doesn't help here, since you have to rehost and usually the same set of players won't join again. Also it can be a lot of work to find the correct settings to satisfy everyone, so rehosting can be a pain.
When looking at the code, I see the need for a complete rewrite of the gamesetup too. But that doesn't mean that we can't fix this problem for the next release by removing 4 lines of code (L980-984
) before that will happen.
I also understand that some random maps might not want to support all victory conditions in the future. However this feature is not implemented. If it was implemented then the victory condition shouldn't be reset, unless the choice is not supported by the map.
by , 9 years ago
Attachment: | t3209_keep_victory_condition_minimum.patch added |
---|
All that im asking for in this ticket.
comment:6 by , 9 years ago
Keywords: | patch review removed |
---|
comment:7 by , 9 years ago
r17026 finds a compromise between r16238 and r16840. The removed code was needed for a bug described in ticket:3001#comment:6.
This problem is different from #3184. That bug made you play conquest even if you had selected wonder mode in the gamesetup.
The problem I want to address here is that the victory condition is set to conquest each time after changing the map in the gamesetup. So you still have a chance of noticing the changed setting before starting the game (contrary to #3184).