Opened 5 years ago

Closed 4 years ago

#2973 closed enhancement (wontfix)

[PATCH] Enable JS Debugger SM 31

Reported by: trompetin17 Owned by: trompetin17
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

this patch enable js debugger again in sm 24, please review in ways:

  • functionality with jsdebugger tool
  • Code Style
  • Code quality

I tested with Atlas in osx

Attachments (2)

2973.diff (55.1 KB) - added by trompetin17 5 years ago.
2973_continuation1.patch (61.0 KB) - added by Bernard 4 years ago.
Hi, I fixed the gc roots. The game builds completely now but the ThrowHook? doesn't seem to get called. I think this is due to the spidermonkey library. I would like to submit the patch for your review. Cheers!

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by trompetin17

Attachment: 2973.diff added

comment:1 Changed 5 years ago by historic_bruno

This should wait until after the SM 31 upgrade and likely until A19, so it doesn't interfere with that higher priority work. Once SM31 is working on OS X, you could begin updating this patch with any API changes and more in-depth reviewing can proceed.

The only comments I have so far are that the commented out lines in source/ps/GameSetup/Config.cpp should be removed, and can you explain the added commented out block in source/scriptinterface/ThreadDebugger.cpp lines 827-863?

comment:2 Changed 5 years ago by historic_bruno

Summary: Enable JS Debugger SM 24[PATCH] Enable JS Debugger SM 24

comment:3 Changed 5 years ago by Yves

In 16214:

SpiderMonkey 31 upgrade

This upgrade also introduces exact stack rooting (see to the wiki: JSRootingGuide) and fixes problems with moving GC. This allows us to enable generational garbage collection (GGC).
Measurements a few months ago have shown a performance improvement of a non-visual replay of around 13.5%. This probably varies quite a bit, but it should be somewhere between 5-20%. Memory usage has also been improved. Check the forum thread for details.

Thanks to everyone from the team who helped with this directly or indirectly (review, finding and fixing issues, the required C++11 upgrade, the new autobuilder etc.)! Also thanks to the SpiderMonkey developers who helped on the #jsapi channel or elsewhere!

Fixes #2462, #2415, #2428, #2684, #1374
Refs #2973, #2669

comment:4 Changed 5 years ago by historic_bruno

Keywords: review removed

comment:5 Changed 5 years ago by Itms

Milestone: Alpha 18Alpha 19

comment:6 Changed 5 years ago by trompetin17

Owner: set to trompetin17
Status: newassigned

comment:7 Changed 4 years ago by stanislas69

Shouldn't the name be [PATCH] Enable JS Debugger SM 31 ? also are you working on it ?

comment:8 Changed 4 years ago by trompetin17

Milestone: Alpha 19Alpha 20
Summary: [PATCH] Enable JS Debugger SM 24[PATCH] Enable JS Debugger SM 31

this patch need to review with SM 31 i will push in a20

Changed 4 years ago by Bernard

Attachment: 2973_continuation1.patch added

Hi, I fixed the gc roots. The game builds completely now but the ThrowHook? doesn't seem to get called. I think this is due to the spidermonkey library. I would like to submit the patch for your review. Cheers!

comment:9 Changed 4 years ago by leper

Resolution: fixed
Status: assignedclosed

comment:10 Changed 4 years ago by leper

Resolution: fixed
Status: closedreopened

comment:11 Changed 4 years ago by leper

Resolution: wontfix
Status: reopenedclosed

That API was removed as a part of #3708. See #410 for a slightly updated description of what should be done.

Note: See TracTickets for help on using tickets.