[PATCH] Enable JS Debugger SM 31

[trompetin17]

this patch enable js debugger again in sm 24, please review in ways:

• functionality with jsdebugger tool
• Code Style
• Code quality

I tested with Atlas in osx

[historic_bruno]

This should wait until after the SM 31 upgrade and likely until A19, so it doesn't interfere with that higher priority work. Once SM31 is working on OS X, you could begin updating this patch with any API changes and more in-depth reviewing can proceed.

The only comments I have so far are that the commented out lines in source/ps/GameSetup/Config.cpp should be removed, and can you explain the added commented out block in source/scriptinterface/ThreadDebugger.cpp lines 827-863?

[Yves]

In 16214:

SpiderMonkey 31 upgrade

This upgrade also introduces exact stack rooting (see to the wiki: JSRootingGuide) and fixes problems with moving GC. This allows us to enable generational garbage collection (GGC).
Measurements a few months ago have shown a performance improvement of a non-visual replay of around 13.5%. This probably varies quite a bit, but it should be somewhere between 5-20%. Memory usage has also been improved. Check the forum thread for details.

Thanks to everyone from the team who helped with this directly or indirectly (review, finding and fixing issues, the required C++11 upgrade, the new autobuilder etc.)! Also thanks to the SpiderMonkey developers who helped on the #jsapi channel or elsewhere!

Fixes #2462, #2415, #2428, #2684, #1374
Refs #2973, #2669

[Stan]

Shouldn't the name be [PATCH] Enable JS Debugger SM 31 ? also are you working on it ?

[trompetin17]

this patch need to review with SM 31 i will push in a20

[Bernard]

Hi, I fixed the gc roots. The game builds completely now but the ThrowHook doesn't seem to get called. I think this is due to the spidermonkey library. I would like to submit the patch for your review. Cheers!

[leper]

In 17655:

Remove JSDebugger. Closes #2419, #2973. Refs #410, #2348, #3708.

​https://bugzilla.mozilla.org/show_bug.cgi?id=1069694

[leper]

That API was removed as a part of #3708. See #410 for a slightly updated description of what should be done.