[PATCH] Set the traded goods for every Trader in a selected group of Traders

[michael]

Set the traded goods for every Trader in a selected group of Traders. Eliminates having to do it one at a time.

Currently, you can only set the trade goods on one trader at a time. It would be best if this could be done with multiple selected traders at once.

[michael]

Currently, if you attempt to do this for multiple traders, it will only happen to one of them.

[O.Davoodi]

Patch for ticket 1209

[O.Davoodi]

Patch submitted. Works for land traders, ships and a combination of both.

[Philip Taylor]

GetEntityState(selection[j]).id is equivalent to selection[j] (since the argument to GetEntityState is the ID), so you can simplify that. Then you can simplify the entire loop to "selectionUnitIDs = selection". And then you can just pass selection directly into selectTradingPreferredGoodsData instead of adding any new variables at all :-)

The "trader" in the command data (and in the command in selectTradingPreferredGoods and in Commands.js) should be renamed to "traders" since it's now an array of IDs. But actually it should probably be renamed to "entities" instead, for consistency with all the other commands.

[O.Davoodi]

Sorry input.js is not related to this. Updated the patch with Philip's instructions.

[Kieran P]

Hey Spahbod. Thanks for your work. To help the patch reviewers, can you please combine patches into a single file, and timestamp them. Something like "1209_2012-03-22.patch". This helps find exactly which patches are the newest ones to review, and how old they are. Thanks.

[leper]

In 11442:

Set goods for every selected trader. Based on patch by Spahbod, fixes #1209.

[leper]

Thanks for the patch. As k776 said it would be great if you could provide a single patch file instead of multiple files.