editor: OpenGL errors

[fabio]

When running '0ad -editor' I get the following GL errors (note also that I am using mesa compiled with --enable-debug which shows also some other useful errors):

$ ./0ad -editor
[Thread debugging using libthread_db enabled]
TIMER| LoadDLL: 621.435 ms
[New Thread 0xb5befb70 (LWP 2897)]
Cache: 200 (total: 1493) MiB
[New Thread 0xa7adfb70 (LWP 2898)]
TIMER| InitVfs: 2.28409 ms
TIMER| InitScripting: 1.73954 ms
TIMER| CONFIG_Init: 5.40969 ms
[New Thread 0xa6cffb70 (LWP 2899)]
[New Thread 0xa64feb70 (LWP 2900)]
[New Thread 0xa44feb70 (LWP 2901)]
r300: DRM version: 2.9.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2
r300: GART size: 509 MB, VRAM size: 256 MB
r300: AA compression RAM: YES, Z compression RAM: YES, HiZ RAM: YES
APIC: not unique
TIMER| RunHardwareDetection: 19.6156 ms
[New Thread 0xa37e8b70 (LWP 2902)]
TIMER| InitRenderer: 3.03768 ms
TIMER| ps_console: 15.347 ms
TIMER| ps_lang_hotkeys: 1.26615 ms
TIMER| common/emptyinit.xml: 817.491 us
GAME STARTED, ALL INIT COMPLETE
Mesa: User error: GL_INVALID_VALUE in glScissor
GL_INVALID_VALUE
OpenGL error(s) occurred: 0501
Mesa: User error: GL_INVALID_VALUE in glOrtho
ERROR: CRenderer::EndFrame: GL errors occurred
TIMER| shutdown actor stuff: 2.654 us
TIMER| shutdown TexMan: 3.562 us
[Thread 0xa37e8b70 (LWP 2902) exited]
TIMER| shutdown Renderer: 4.92157 ms
TIMER| shutdown SDL: 655.111 us
TIMER| shutdown UserReporter: 2.445 us
TIMER| shutdown ScriptingHost: 596.235 us
TIMER| shutdown ConfigDB: 2.165 us
TIMER| resource modules: 12.4155 ms
TIMER TOTALS (9 clients)
-----------------------------------------------------
  xml_validation: 21.1427 Mc (19x)
  tc_ShaderValidation: 8672.78 kc (17x)
  tc_pool_alloc: 10.9776 Mc (3494x)
  tc_linkProgram: 0 c (0x)
  tc_compileShader: 0 c (0x)
  tc_transform: 1554.28 kc (126x)
  tc_plain_transform: 346.502 kc (126x)
  tc_dds_transform: 1018.72 kc (378x)
  tc_png_decode: 12.245 Mc (16x)
-----------------------------------------------------
TIMER| shutdown misc: 573.187 us
[Thread 0xb5befb70 (LWP 2897) exited]
lost connection to FAM[Thread 0xa7adfb70 (LWP 2898) exited]
[Thread 0xa64feb70 (LWP 2900) exited]
[Thread 0xa6cffb70 (LWP 2899) exited]
[Thread 0xa44feb70 (LWP 2901) exited]

Program exited normally.

I recall I see something similar already reported on the forums. EDIT: forum thread: http://www.wildfiregames.com/forum/index.php?showtopic=15164

[historic_bruno]

Thanks fabio, that is useful info :) Probably the GL errors are a symptom rather than the cause. The best lead I've found so far is some recommendations that SDL_SetVideoMode (and other windowing functions) be run from the main thread, which was the case previously but now it's run from a secondary thread (an attempt to fix Atlas for OS X). I'm not sure why the problem only occurs when using the -editor flag.

[historic_bruno]

I tried reverting the Atlas threading changes from [10299] on 64-bit Ubuntu. In fact the Atlas GL errors still persist (and the shader issues when using the -editor flag). This is not the only graphical defect people are reporting with Alpha 7 (#966, #1005), so I think the renderer changes from [9814] should be examined for bugs.

Also the Atlas errors only occur in Linux, not OS X or Windows.

[Philip Taylor]

Looks like it's just trying to render when g_xres=g_yres=0 before the canvas size has been set, so glScissor/glOrtho are passed zeroes and complain.

[philip]

(In [10526]) Set Atlas canvas size before potentially rendering to it. Fixes #987.