Opened 7 years ago
Last modified 4 years ago
#4661 new defect
Don't reset game type for skirmish maps
Reported by: | Imarok | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | Atlas editor | Keywords: | |
Cc: | Patch: |
Description
There is no need to reset the game type for skirmish maps when changing the map. refs #3209.
Change History (5)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
Component: | UI & Simulation → Game setup |
---|
Move tickets to Game Setup
as UI & Simulation
got some sub components.
comment:3 by , 4 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Owner: | set to |
Patch: | → Phab:D2483 |
comment:4 by , 4 years ago
Component: | UI – Game setup → Atlas editor |
---|---|
Milestone: | Alpha 24 → Backlog |
Patch: | Phab:D2483 |
Atlas writes the VictoryConditions? to all saved maps, and Atlas doesn't work correctly if they're not specified, so the issue is not limited to the gamesetup part (but the gamesetup part will be fixed by Phab:D2483).
Note:
See TracTickets
for help on using tickets.
Skirmish maps come with defaults, so if user settings are persisted, the map defaults will either not be loaded (then why do defaults exist if they're not used), or the user settings are persisted and the defaults overwrite them (so the user will not notice that one setting was changed by the map while all other user settings persisted.)
For that reason it makes some sense that all values are reset to default for skirmish maps, as this informs the user that his previously chosen settings are overwritten. For the same reason I lobby that random maps are not allowed to specify values (as setting persistance is crucial in multiplayer).
So either implement setting persistance for all settings on skirmish maps and drop skirmish map defaults, or keep as is IMO.